Activity log for bug #1503730

Date Who What changed Old value New value Message
2015-10-07 15:09:27 Marcus Tomlinson bug added bug
2015-10-07 15:09:58 Marcus Tomlinson summary "new"ing a class from JS creates a raw pointer constructing a class from JS returns a raw pointer
2015-10-07 15:10:10 Marcus Tomlinson summary constructing a class from JS returns a raw pointer Constructing a class from JS returns a raw pointer
2015-10-07 15:10:32 Marcus Tomlinson summary Constructing a class from JS returns a raw pointer Constructing a class from JS should return a shared_ptr not a raw pointer
2015-10-07 15:11:12 Marcus Tomlinson description At the moment if you "new" a bound class from within JS it returns a raw pointer to the allocated memory. This makes things really complicated when trying to pass those objects into a methods that take shared_ptr arguments. We should be creating a shared_ptr upon construction and passing that back to JS. This naturally also gives us better lifecycle control of these objects between JS and C++. At the moment if you "new" a bound class from within JS it returns a raw pointer to the allocated memory. This makes things really complicated when trying to then pass those objects into a methods that take shared_ptr arguments. We should be creating a shared_ptr upon construction and passing that back to JS. This will naturally gives us better lifecycle control of these objects between JS and C++ as well.
2015-10-07 15:11:42 Marcus Tomlinson v8-cpp: assignee Marcus Tomlinson (marcustomlinson)
2015-10-07 15:11:45 Marcus Tomlinson v8-cpp: status New Fix Committed