Hashes mutate on rich history reimport

Bug #1876329 reported by Robie Basak on 2020-05-01
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Robie Basak

Bug Description

Now that we have landed rich history preservation, it occurred to me that as we are regenerating upload tags when --reimport is used unconditionally, a reimport of a new existing hash-stable import will also cause those regenerations. Each regeneration uses commit dates of the time of the regeneration, so this will mutate commit hashes. So repeated reimports of a repository with rich history will result in different hashes every time.

This isn't an immediate problem since we only intend to reimport everything once, but it is a shortcoming in the behaviour of --reimport. It would be better if we only regenerated upload tags when the base commits of the rich history has actually changed. However even in hindsight I don't think it would have been worth implementing this already.

I'm leaving this as a low importance bug for the future.

Related branches

Robie Basak (racb) on 2020-05-28
Changed in usd-importer:
status: Triaged → In Progress
assignee: nobody → Robie Basak (racb)
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers