if target branches are prefixed with the remote silently retry without

Bug #1756088 reported by Christian Ehrhardt  on 2018-03-15
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
usd-importer
Low
Unassigned

Bug Description

Several of the git ubuntu actions might require the user to specify a branch.
The obvious way to check that is in git log and similar output.
But there it is prefixed with the remote.

So the ubuntu/bionic-devel branch looks like pkg/ubuntu/bionic-devel

But if one just copies that it will fail
git ubuntu submit ... --target-branch pkg/ubuntu/bionic-devel
03/15/2018 15:04:49 - ERROR:Unable to create merge proposal: HTTP Error 400: Bad Request
Response headers:
---
connection: close
content-length: 40
content-type: text/plain;charset=utf-8
date: Thu, 15 Mar 2018 14:04:49 GMT
server: zope.server.http (HTTP)
status: 400
strict-transport-security: max-age=15552000
vary: Accept
x-content-type-options: nosniff
x-frame-options: SAMEORIGIN
x-launchpad-revision: 18571
x-lazr-notifications: []
x-powered-by: Zope (www.zope.org), Python (www.python.org)
x-xss-protection: 1; mode=block
---
Response body:
---
b'merge_target: Required input is missing.'
---

This affects submit and lint, maybe more.
The errors are different, the above is of submit not finding things on launchpad.

I think we should at least try to make the error more readable a la "this target branch does not exists" or even try to derive "the right thing" in those cases we can.

IMHO a nice but low prio improvement.

Changed in usd-importer:
importance: Undecided → Low
tags: added: lint submit
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers