build with pristine-tar is unable to proceed with a dirty tree

Bug #1714560 reported by Nish Aravamudan on 2017-09-01
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
usd-importer
Wishlist
Robie Basak

Bug Description

We have put in code (c52db813e) to not build if the tree is dirty. This is overkill, so that pristine-tar is used, because `gbp` can't handle the tree being dirty (I believe it has to manipulate the working-tree). Either gbp should be adjusted to use a working-dir distinct from the current one, or we should dupe our repo somewhere else while we run some specific commands in it (and then put the results where we expect them to be)).

The latter solution is more generic and would also resolve LP: #1708203.

Nish Aravamudan (nacc) on 2017-09-01
Changed in usd-importer:
milestone: none → 1.0
Nish Aravamudan (nacc) wrote :

This is now possible, so we can make this work, I think.

Changed in usd-importer:
assignee: nobody → Nish Aravamudan (nacc)
Nish Aravamudan (nacc) on 2017-10-26
Changed in usd-importer:
status: New → Confirmed
Nish Aravamudan (nacc) wrote :

Given that we, for now, are not going to allow building dirty trees, this is not as important of a problem to solve. It can be, in general, if we decide it should be, by using a temporary directory with a temporary worktree in a subdirectory, and extract the pristine-tar tarballs to the temporary directory, then copy them to the parent directory.

Changed in usd-importer:
milestone: 1.0 → future
assignee: Nish Aravamudan (nacc) → nobody
importance: Undecided → Wishlist
assignee: nobody → Robie Basak (racb)
Nish Aravamudan (nacc) wrote :

@Robie, I'm assigning to you, for now, because it's a matter of questioning what the various methods in build.py should do when in a given repository state.

Robie Basak (racb) on 2017-11-28
tags: added: build
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers