Adopting just from upload tags does not incorporate git notes

Bug #1650509 reported by Robie Basak on 2016-12-16
This bug affects 1 person
Affects Status Importance Assigned to Milestone

Bug Description

Notes would have to be fetched, merged and pushed separately with some management inside refs/notes/commits I think. We'd like to keep these around.

Perhaps we should just adopt all notes from the upload tag staging area. Then any person who can push there can edit all notes, but that could be exactly what we want.

Nish Aravamudan (nacc) on 2016-12-19
Changed in usd-importer:
importance: Undecided → Medium
Nish Aravamudan (nacc) wrote :

I think we should fix-up this case along with everything else to do with upload tags in the namespace rework? (next on my todo)

Changed in usd-importer:
assignee: nobody → Nish Aravamudan (nacc)
status: New → In Progress
Nish Aravamudan (nacc) wrote :

So this affects our refspecs, right? Do you want to work on this, Robie, with an adjustment to the specification?

Robie Basak (racb) wrote :

Sure. I think all notes just get merged in though. I'll need to check.

Nish Aravamudan (nacc) on 2017-05-25
Changed in usd-importer:
assignee: Nish Aravamudan (nacc) → nobody
assignee: nobody → Robie Basak (racb)
Nish Aravamudan (nacc) on 2017-08-02
Changed in usd-importer:
milestone: none → 1.0
Robie Basak (racb) on 2017-08-02
Changed in usd-importer:
status: In Progress → Triaged
assignee: Robie Basak (racb) → nobody
Nish Aravamudan (nacc) wrote :

@racb: is this just a matter of adjusting our default refspecs? Should we defer this for 1.0?

Robie Basak (racb) wrote :

I'm not sure adjusting refspecs is sufficient. It may take some experimentation.

In the interest of getting 1.0 out, I think it's OK to defer. We just won't "support" git notes in rich history until this is implemented. At that point, we'll also need to have hash abi versioning in place for reproducibility.

Robie Basak (racb) on 2017-11-28
tags: added: import
Robie Basak (racb) on 2018-05-24
tags: added: spec
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers