devpts is mounted incorrectly in the non-initrd case

[Adam Conrad]

In most places in Ubuntu, devpts is mounted correctly with gid=5,mode=620, however upstart itself mounts it incorrectly in the cases when it's not already mounted by something else:

init/main.c: if (system_mount ("devpts", "/dev/pts", (MS_NOEXEC | MS_NOSUID)) < 0)

Compare to, say, systemd, which does this:

#ifndef TTY_GID
#define TTY_GID 5
#endif
[...]
src/core/mount-setup.c: { "devpts", "/dev/pts", "devpts", "mode=620,gid=" STRINGIFY(TTY_GID), MS_NOSUID|MS_NOEXEC,

Please fix this up, as this will explode in special and fun ways when pt_chown goes away and we stop falling back on it as a crutch when the devpts permissions are wrong.

[Steve Langasek (vorlon)]

Marking 'medium' since this code path is only used in initramfsless systems, which are not the common case.

[Adam Conrad (adconrad)]

This appears to have been fixed both upstream and in Ubuntu, but without the bug being twiddled.