job_process_spawn() uses incorrect NIH calls for some errors

Bug #1032101 reported by James Hunt
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Fix Released
James Hunt

Bug Description

init/job_process.c:job_process_spawn() is using nih_return_error() in some instances which is invalid (since these calls are being made in the child process).

Also, some calls to job_process_error_abort() are invalid as they are not matched with a previous call to nih_error_raise_system(). This can lead to assertion failures if an error is detected in the child process.

Noticed when investigating bug 980917.

Related branches

James Hunt (jamesodhunt)
Changed in upstart:
importance: Undecided → Medium
assignee: nobody → James Hunt (jamesodhunt)
James Hunt (jamesodhunt)
Changed in upstart:
status: New → Fix Released
James Hunt (jamesodhunt)
Changed in upstart:
status: Fix Released → Fix Committed
Revision history for this message
Dimitri John Ledkov (xnox) wrote :

revno: 1374 [merge]
fixes bug:
committer: Steve Langasek <email address hidden>
branch nick: upstream
timestamp: Thu 2012-08-02 11:44:56 -0700
  Merge fix for bug #1032101

Changed in upstart:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.