URC does not handle errors in retrieving the router icon

[Daniele Napolitano]

Originally reported by Dimitris Pitsioris.

URC tries to download and apply it in the GUI even if the request ends in HTTP 404, in some cases leave the space of the icon blank but running URC with root the downloading ends in a segmentation fault.

$ upnp-router-control --debug
* Initializing GUI...
* Showing GUI...
* Starting UPnP Resource discovery... lo: host IP 127.0.0.1 network 127.0.0.0
* Starting UPnP Resource discovery... eth0: host IP 192.168.1.2 network 192.168.1.0
==> Device Available: UPNP IGD
*** Selected IGD complaiant device
    Model description: ZTE Broadband Home Gateway
           Model name: Speedport Entry 2i
         Model number: V1.0
                Brand: OTE
     Presentation URL: http://192.168.1.1/
                  UPC:
   Unique Device Name: [hidden]
             Icon URL: http://192.168.1.1:52869/ligd.gif
       Icon mime/type: image/gif
           Icon depth: 8
           Icon width: 118
          Icon height: 119
Downloading router icon...
     Enum services...
       Service: urn:microsoft-com:serviceId:OSInfo1
          Type: urn:schemas-microsoft-com:service:OSInfo:1
     Enum sub-devices...
       Sub-Device: UPNP IGD
         Enum sub-devices...
           Sub-Device: UPNP IGD
Router icon downloaded

# upnp-router-control
* Initializing GUI...
* Showing GUI...
* Starting UPnP Resource discovery... lo: host IP 127.0.0.1 network 127.0.0.0
* Starting UPnP Resource discovery... eth0: host IP 192.168.1.2 network 192.168.1.0
==> Device Available: UPNP IGD
*** Selected IGD complaiant device
Downloading router icon...
Segmentation fault

-----

Affected URC version: 0.3

[MestreLion (mestrelion)]

I noticed this was fixed by completely removing the icon functionality. Any change to get this back? Are you interested in a PR that implements this? (of course, handling 404 and other errors).

Most likely libcurl is not even needed: since we're talking about Routers accessible by LAN, its icon URLs are also accessible. I'm sure theres a GUI Widget in GTK3 that allows specifying a URL/URI as the image source, so no download is necessary.