internal Ubuntu.Connectivity module has a name clash with the public module

Bug #1360703 reported by Antti Kaijanmäki
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
unity8 (Ubuntu)
Fix Released
Critical
Michał Sawicz
unity8 (Ubuntu RTM)
Fix Released
Critical
Unassigned

Bug Description

in plugins/Ubuntu/Connectivity:
add_unity8_plugin(Ubuntu.Connectivity 0.1 Ubuntu/Connectivity TARGETS Connectivity)

and it's imported in qml/Shell.qml:
import Ubuntu.Connectivity 0.1

The import clashes with the public module:
http://developer.ubuntu.com/api/qml/sdk-14.10/Ubuntu.Connectivity.index/

The unity8 module must be renamed to Ubuntu.Connectivity.Private

Related branches

Revision history for this message
Michał Sawicz (saviq) wrote :

Remember the plugins unity8 ships are not installed to the default import path, so only unity8 is affected by this, nothing else.

While potentially confusing, not critical. Reducing importance, thus.

Changed in unity8:
importance: Critical → High
assignee: Michał Sawicz (saviq) → Michael Terry (mterry)
Revision history for this message
Antti Kaijanmäki (kaijanmaki) wrote :

But if the default QML import path is search before unity's own import path, the import statement will fail and unity8 Shell.qml fails to load.

Revision history for this message
Antti Kaijanmäki (kaijanmaki) wrote :

not if, when:
file:///usr/share/unity8/Shell.qml:23:1: module "Ubuntu.Connectivity" version 0.1 is not installed
     import Ubuntu.Connectivity 0.1
     ^

Changed in unity8:
importance: High → Critical
Revision history for this message
Antti Kaijanmäki (kaijanmaki) wrote :

To prevent this from happening again, I would suggest that all of the private unity8 modules would actually be namespaced as private:

// import private unity8 plugin
import Unity.Private.Foo

Changed in unity8:
status: Triaged → In Progress
assignee: Michael Terry (mterry) → Michał Sawicz (saviq)
Changed in unity8 (Ubuntu RTM):
status: New → Triaged
importance: Undecided → Critical
Revision history for this message
Michał Sawicz (saviq) wrote :

In silo 4 under QA.

Changed in unity8:
status: In Progress → Fix Released
Changed in unity8 (Ubuntu RTM):
status: Triaged → In Progress
Michał Sawicz (saviq)
Changed in unity8 (Ubuntu RTM):
status: In Progress → Fix Released
Michał Sawicz (saviq)
affects: unity8 → unity8 (Ubuntu)
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.