In horizontal card layout, margin between art and text is too small

Bug #1326397 reported by Chris Wayne
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
The Savilerow project
Fix Released
Undecided
Unassigned
unity8 (Ubuntu)
Fix Released
High
Albert Astals Cid

Bug Description

When creating a scope that shows results as horizontal cards with art and a title/subtitle, the art and title/subtitle are too close together, almost touching

Tags: scope-dev

Related branches

Revision history for this message
Chris Wayne (cwayne) wrote :
Revision history for this message
Albert Astals Cid (aacid) wrote :

Can we have such scope? Or at least the components/template it uses?

Revision history for this message
Victor Tuson Palau (vtuson) wrote :

{u'schema-version': 1, u'components': {u'art': {u'field': u'art', u'aspect-ratio': 1.6, u'fill-mode': u'fit'}, u'summary': u'summary', u'subtitle': u'subtitle', u'title': u'title'}, u'template': {u'category-layout': u'grid', u'card-size': u'small', u'card-layout': u'horizontal'}}

Revision history for this message
Victor Tuson Palau (vtuson) wrote :
Michał Sawicz (saviq)
Changed in unity8:
status: New → Triaged
importance: Undecided → High
assignee: nobody → Albert Astals Cid (aacid)
Revision history for this message
Albert Astals Cid (aacid) wrote :

What version of unity8 are you guys using?

I get http://i.imgur.com/n1A0QBi.png with the trunk version of unity8 (it's not nice, but it's totally different from what you get) when using Victor's code

Revision history for this message
Albert Astals Cid (aacid) wrote :

My version looks weird because Victor's code says there will be art, but then there's never art, just the mascot

Revision history for this message
Michał Sawicz (saviq) wrote :

Indeed, it seems like the code wasn't updated. In any case, here's a patch that made it *better*, although not great. We'll look into the issue, but from the looks of it we're forcing header height on the art, instead of the other way around.

Revision history for this message
Michał Sawicz (saviq) wrote :
Revision history for this message
Albert Astals Cid (aacid) wrote :

The fix for saviq's problem is at ~aacid/unity8/obeyArtShapeFixedSize so i'll link that branch to this bug assuming that is the problem we actually have.

Changed in unity8:
status: Triaged → In Progress
Michał Karnicki (karni)
tags: added: scope-dev
Revision history for this message
Albert Astals Cid (aacid) wrote :
Changed in unity8:
status: In Progress → Fix Released
Chris Wayne (cwayne)
Changed in savilerow:
status: New → Fix Released
Michał Sawicz (saviq)
affects: unity8 → unity8 (Ubuntu)
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.