LimitProxyModel doesn't properly handle insertions
Bug #1213959 reported by
Michal Hruby
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
unity8 (Ubuntu) |
Fix Released
|
High
|
Albert Astals Cid |
Bug Description
When doing insertions (for example insert to pos #0, when there are already 10 rows), the LimitProxyModel doesn't properly remove the rows that are pushed beyond the limit, resulting in incorrect behavior.
(similar issue when removing result from the middle which should push currently invisible rows to visible positions)
To reproduce, try searching for "f" in the applications lens, if the "Dash plugins" category is collapsed you'll see only one result, but if it's expanded before the search it'll show 5 results.
Related branches
lp:~aacid/unity8/fix_qlimitproxymodel
- PS Jenkins bot (community): Approve (continuous-integration)
- Michal Hruby (community): Approve
-
Diff: 321 lines (+225/-12)3 files modifiedplugins/Utils/qlimitproxymodelqml.cpp (+90/-4)
plugins/Utils/qlimitproxymodelqml.h (+2/-0)
tests/plugins/Utils/qlimitproxymodeltest.cpp (+133/-8)
Changed in unity8: | |
assignee: | nobody → Albert Astals Cid (aacid) |
status: | New → Confirmed |
importance: | Undecided → High |
description: | updated |
Changed in unity8: | |
status: | Confirmed → In Progress |
Changed in unity8: | |
status: | Fix Committed → Fix Released |
Changed in unity8 (Ubuntu): | |
assignee: | nobody → Albert Astals Cid (aacid) |
importance: | Undecided → High |
no longer affects: | unity8 |
To post a comment you must log in.
Fix committed into lp:unity8 at revision 230, scheduled for release in unity8, milestone Unknown