ResultIterator.h defines functions that return const values

Bug #1163705 reported by Michi Henning
0
Affects Status Importance Assigned to Milestone
Unity
Status tracked in Trunk
6.0
Won't Fix
Undecided
Unity Team
7.0
Won't Fix
Undecided
Unity Team
Phablet-mods
Fix Committed
Undecided
Unity Team
Trunk
Fix Released
Undecided
Unity Team
unity (Ubuntu)
Fix Released
Undecided
Unassigned

Bug Description

In UnityCore/ResultIterator.h, we have things such as:

friend inline bool const operator<(const ResultIterator& lhs, const ResultIterator& rhs)

and

bool const IsLast();

Declaring a function to return a const value is meaningless, and the compiler ignores the const. Moreover, with -Wall -Wextra, gcc emits a warning about the ignored const and, with -Werror, produces an error.

The const return values need to be non-const.

Related branches

Changed in unity:
assignee: nobody → Michi Henning (michihenning)
status: New → In Progress
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

Fix committed into lp:unity at revision None, scheduled for release in unity, milestone backlog

Changed in unity:
status: In Progress → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package unity - 7.0.0daily13.04.10-0ubuntu1

---------------
unity (7.0.0daily13.04.10-0ubuntu1) raring; urgency=low

  [ Andrea Azzarone ]
  * Launcher icons automatically placed in the launcher by USC (or apps
    lens) fail to have running 'pips'. (LP: #1165097)

  [ Marco Trevisan (Treviño) ]
  * Unity wastes some memory by allocating multiple times the same
    texture (LP: #1166532)
  * Unity is creating multiple instances of DBusIndicators per each
    monitor (LP: #1166550)

  [ Michi Henning ]
  * ResultIterator.h defines functions that return const values (LP:
    #1163705)

  [ Ubuntu daily release ]
  * Automatic snapshot from revision 3290
 -- Ubuntu daily release <email address hidden> Wed, 10 Apr 2013 04:03:19 +0000

Changed in unity (Ubuntu):
status: New → Fix Released
no longer affects: unity/phablet
Revision history for this message
Stephen M. Webb (bregma) wrote :

Released in Unity 7.1

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.