Dash/HUD - Spinner off-centre, looks drunk

Bug #943656 reported by Andrea Cimitan on 2012-02-29
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Unity
Fix Released
Medium
Unassigned
unity (Ubuntu)
Undecided
Unassigned

Bug Description

The spinner asset in the dash/HUD search box, while animated, bounces up and down...

Related branches

Revision history for this message
Paul Sladen (sladen) wrote :

Confirming. Looks like an off-by-one in either the code of the asset.

Changed in unity:
status: New → Confirmed
Revision history for this message
Omer Akram (om26er) wrote :

indeed that's drunk lol.

Changed in unity:
importance: Undecided → Medium
Revision history for this message
Paul Sladen (sladen) wrote :

Asset is 'unity/plugins/unityshell/resources/search_spin.png' (48x48). This is pixel-perfect aligned to the accompanying 'search_magnify.png'.

'unity/plugins/unityshell/src/DashStyle.cpp' has the loading routine which returns it via 'Style::GetSearchSpinIcon()' and then ultimately it gets used in 'plugins/unityshell/src/SearchBarSpinner.cpp::SearchBarSpinner::Draw()'.

My hunch at this stage is that 'spin_offset_w' is probably not taking account of OpenGL textures being measured from the pixel sample centre.

Revision history for this message
Paul Sladen (sladen) wrote :

Testing regime:

  1. Hold down 'Alt' to activate HUD
  2. Type a single character (eg. 'a')
  3. Observe spinner rotating off-centre

Repeat with patch:

  4. Observe that spinner is no long acentric.

Changed in unity:
status: Confirmed → Fix Committed
Didier Roche (didrocks) on 2012-03-23
Changed in unity:
milestone: none → 5.8.0
Didier Roche (didrocks) on 2012-03-23
Changed in unity:
status: Fix Committed → Fix Released
Revision history for this message
Launchpad Janitor (janitor) wrote :
Download full text (5.4 KiB)

This bug was fixed in the package unity - 5.8.0-0ubuntu1

---------------
unity (5.8.0-0ubuntu1) precise-proposed; urgency=low

  * New upstream release.
    - New "push mouse offscreen" feature really difficult to get (LP: #923749)
    - unity-2d-panel crashed with SIGSEGV in
      unity::indicator::DBusIndicators::Impl::RequestSyncAll() (LP: #864737)
    - Pressing "Alt+Enter" causes compiz to crash in CompOption::value() from
      unity::UnityScreen::showLauncherKeyTerminate (LP: #960957)
    - SEGSIGV after unplugging external monitor (LP: #962693)
    - Background colorization should use a different heuristic (LP: #865239)
    - compiz+unity3d generates > 50 wakeups a second on idle system
      (LP: #917210)
    - [FFe, UIFe] HUD - The HUD does not respect launcher autohide or icon
      size settings (LP: #921506)
    - clicking on folders in the file lens does not open nautilus
      (LP: #921665)
    - No text inside multirange filters (LP: #927710)
    - can't alt-tab restore minimized uis which have an instance on another
      workspace (LP: #933397)
    - Ubuntu Software Center Unity launcher integration is not working
      (LP: #932280)
    - The line separator between the launcher and the dash is cleared when
      selecting a category (LP: #941082)
    - unity-panel-service crashed with SIGSEGV in g_hash_table_foreach()
      (LP: #937119)
    - Alt-F10 locks up Unity (LP: #948522)
    - multimonitor, launcher: Provide an option to display either a single
      launcher or a launcher on each display in a multi-monitor environment
      (LP: #950136)
    - multimonitor: Please give me a way to turn off sticky monitor edges
      (LP: #946104)
    - Unity 5.6: key bindings (such as Super) don't work on empty workspace or
      on slow/loaded systems (LP: #953089)
    - Alt+arrows keyboard shortcuts don't invoke Back and Forward navigation
      (LP: #953783)
    - HUD is sending 2 menu signals instead of 1 (LP: #956878)
    - 6th item of HUD not fully visible (LP: #957229)
    - HUD: seems to trigger operations more than once (LP: #960503)
    - Launcher gets always desaturated when using HUD on secondary monitor
      (LP: #961169)
    - [5.8 pre staging] launcher is displayed on the left screen, not the
      primary one (LP: #961281)
    - launcher icons do not re-saturate after dash is closed (LP: #961844)
    - Launcher shows arrows for applications on all workspaces (LP: #961977)
    - Dash - Implement overlay scrollbars in Dash (LP: #608124)
    - [UIFe] Dash - No message displayed when no results are returned in the
      Dash (LP: #711199)
    - Dash - "See more..." line should be base-aligned with section header
      (LP: #748101)
    - Dash - Missing category separator line in dash (LP: #850984)
    - Dash and Launcher - As soon as a user starts dragging a file from the
      Dash, there is a 'flicker' before the Launcher icons that are valid drop
      receptacles re-saturate (LP: #863230)
    - Dash - When multiple results have equal string match relevancy ranking,
      those with equal ranking should be then sorted by frequency of use.
      (LP: #871900)
    - Keyboard shortcut - F10 shortcut is used to show m...

Read more...

Changed in unity (Ubuntu):
status: New → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers