Launcher - Quicklist's "Quit" item removal is confusing

Reported by Neil J. Patel on 2011-10-17
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Ayatana Design
Low
John Lea
Unity
Low
Marco Trevisan (Treviño)
unity (Ubuntu)
Low
Marco Trevisan (Treviño)

Bug Description

At the moment, if an application sets a quicklist menu and in that menu an item has a name that matches _("Quit"), we automatically remove our own Quit item from the standard actions section, so the menu looks like:

-------------------------------------
| Refresh
-------------------------------------
| Send
-------------------------------------
| Quit
-------------------------------------
| Gwibber Social Client
-------------------------------------
| [x] Keep In Launcher
-------------------------------------

The problem with this is, when you go to quit the application, it jarring that the option has moved.

Proposed solution 1: we should hide their Quit action, but relay clicking on our Quit-item to their Quick-item's action. So we don't move the Quit button but they get to do whatever it is they want to do before quitting.

Proposed solution 2: We just hide their quit, as we don't want to change what our Quit does

It is proposed that we proceed with 'solution 2' on the basis that this approach will cause the least issues.

Related branches

lp:~3v1n0/unity/app-quicklist-quit-override
Merged into lp:unity at revision 3397
PS Jenkins bot: Approve (continuous-integration) on 2013-07-02
Christopher Townsend: Approve on 2013-07-01
Neil J. Patel (njpatel) on 2011-10-17
Changed in unity:
status: New → Incomplete
John Lea (johnlea) on 2011-10-17
Changed in ayatana-design:
assignee: nobody → John Lea (johnlea)
description: updated
Changed in ayatana-design:
importance: Undecided → Low
status: New → Fix Committed
Changed in unity:
status: Incomplete → Confirmed
Changed in unity (Ubuntu):
status: New → Confirmed
tags: added: udo
John Lea (johnlea) on 2011-10-18
tags: added: udp
Changed in unity:
milestone: none → backlog
Changed in ayatana-design:
status: Fix Committed → Triaged
Tim Penhey (thumper) on 2011-12-05
tags: added: quicklist
Changed in ayatana-design:
status: Triaged → Fix Committed
Changed in unity:
assignee: Mirco Müller (macslow) → Marco Trevisan (Treviño) (3v1n0)
importance: Undecided → Low
Omer Akram (om26er) on 2012-07-23
Changed in unity (Ubuntu):
importance: Undecided → Low
Tim Penhey (thumper) on 2012-09-14
Changed in unity:
milestone: backlog → none
John Lea (johnlea) on 2012-10-15
Changed in unity:
status: Confirmed → Triaged
Changed in unity (Ubuntu):
status: Confirmed → Triaged
summary: - Quicklist's "Quit" item removal is confusing
+ Launcher - Quicklist's "Quit" item removal is confusing
Changed in unity (Ubuntu):
status: Triaged → In Progress
Changed in unity:
status: Triaged → In Progress
milestone: none → 7.1.0
Changed in unity (Ubuntu):
assignee: nobody → Marco Trevisan (Treviño) (3v1n0)
PS Jenkins bot (ps-jenkins) wrote :

Fix committed into lp:unity at revision None, scheduled for release in unity, milestone 7.1.0

Changed in unity:
status: In Progress → Fix Committed
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package unity - 7.0.1+13.10.20130703-0ubuntu1

---------------
unity (7.0.1+13.10.20130703-0ubuntu1) saucy; urgency=low

  [ Sebastien Bacher ]
  * Depends on the new dconf-cli, we only need the command line tool,
    not the gtk editor.

  [ Marco Trevisan (Treviño) ]
  * ApplicationLauncherIcon: improve the way we override the Quit
    quicklist item If a quit action is defined in static (desktop file
    action) or dynamic way we use it to override the default one,
    placing it to the proper position. Also override more labels by
    default and if a quicklist item has the
    QuicklistMenuItem::QUIT_ACTION_PROPERTY (defined as "unity-quit-
    action") property set to TRUE, then we use this item as the quit
    quicklist item. Factorized the code we use to generate both static
    and dynamic ql items. (LP: #876421)
  * Use connection::Manager to handle the sigc::connection disconnection
    on parent removal.
  * ConnectionManager: add connection::Wrapper to wrap a
    sigc::connection disconnecting it on destruction.
  * Unity: use connection::Wrapper to hold the connections to signals
    and disconnect from them.

  [ Ubuntu daily release ]
  * Automatic snapshot from revision 3402
 -- Ubuntu daily release <email address hidden> Wed, 03 Jul 2013 04:03:31 +0000

Changed in unity (Ubuntu):
status: In Progress → Fix Released
Stephen M. Webb (bregma) wrote :

Fix Released in Unity Unity 7.1.0.

Changed in unity:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers