Launcher - Count indicator should change size depending on the number of digits

Bug #796527 reported by John Lea on 2011-06-13
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ayatana Design
Medium
John Lea
Unity
Medium
Marco Trevisan (Treviño)
7.2
Medium
Marco Trevisan (Treviño)
unity (Ubuntu)
Medium
Marco Trevisan (Treviño)
Trusty
Undecided
Unassigned

Bug Description

[ Impact ]

The count indicator currently stays the same size irrespective of whether it is displaying one or two digits.

Desired solution:
If the count indicator only displays one digit it should be a circle e.g (7)
If the count indicator displays two digits it should be a lozenge shape e.g. two half circles joined by two straight lines e.g. (27)
If the count indicator displays three digits it should be a lozenge shape e.g. two half circles joined by two straight lines e.g (527)

[ Test Case ]

See above.

[ Regression Potential ]

Any code change to the Unity desktop shell has the potential to unleash a new crash or lockup in the desktop.

[ Other Info ]

The Unity SRU fix for Ubuntu 14.04 LTS was cherry-picked from Ubuntu 14.10 where it has been in production use for some months now without apparent regression.

Related branches

lp:~3v1n0/unity/adaptive-icon-count
PS Jenkins bot: Needs Fixing (continuous-integration) on 2014-08-28
Brandon Schaefer: Approve on 2014-08-26
lp:~unity-team/unity/7.2.4
Marco Trevisan (Treviño): Approve on 2014-12-17
John Lea (johnlea) on 2011-06-13
Changed in ayatana-design:
assignee: nobody → John Lea (johnlea)
tags: added: udo
Changed in ayatana-design:
importance: Undecided → Medium
status: New → Fix Committed
status: Fix Committed → Fix Released
John Lea (johnlea) on 2011-06-14
Changed in ayatana-design:
status: Fix Released → Fix Committed
Neil J. Patel (njpatel) on 2011-06-30
Changed in unity:
assignee: nobody → Jason Smith (jassmith)
importance: Undecided → Low
milestone: none → 4.4.0
status: New → Triaged
John Lea (johnlea) on 2011-06-30
Changed in ayatana-design:
status: Fix Committed → Fix Released
Jorge Castro (jorge) on 2011-07-01
tags: added: backlog
Didier Roche (didrocks) on 2011-07-05
Changed in unity (Ubuntu):
status: New → Triaged
Didier Roche (didrocks) on 2011-07-21
Changed in unity:
milestone: 4.4.0 → 4.6.0
Didier Roche (didrocks) on 2011-08-01
Changed in unity:
milestone: 4.6.0 → 4.8.0
Omer Akram (om26er) on 2011-09-24
Changed in unity (Ubuntu):
importance: Undecided → Low
assignee: nobody → Jason Smith (jassmith)
John Lea (johnlea) on 2011-10-18
tags: added: udp
Changed in unity:
milestone: 4.8.0 → backlog
Changed in ayatana-design:
status: Fix Released → Fix Committed

I think it's because launcher is rendered using nux, not gtk.

2011/11/20, Andrea Azzarone <email address hidden>:
> Why not use
> http://developer.gnome.org/gtk3/stable/GtkNumerableIcon.html?
>
> --
> You received this bug notification because you are subscribed to unity.
> https://bugs.launchpad.net/bugs/796527
>
> Title:
> Launcher - Count indicator should change size depending on the number
> of digits
>
> Status in Ayatana Design:
> Fix Committed
> Status in Unity:
> Triaged
> Status in “unity” package in Ubuntu:
> Triaged
>
> Bug description:
> The count indicator currently stays the same size irrespective of
> whether it is displaying one or two digits.
>
> Desired solution:
> If the count indicator only displays one digit it should be a circle e.g
> (7)
> If the count indicator displays two digits it should be a lozenge shape
> e.g. two half circles joined by two straight lines e.g. (27)
> If the count indicator displays three digits it should be a lozenge shape
> e.g. two half circles joined by two straight lines e.g (527)
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/ayatana-design/+bug/796527/+subscriptions
>

Andrea Azzarone (azzar1) wrote :

@Marco
Launcher doesn't use nux widget and we already use gtk/gdk function to get the icon pixbuf.

John Lea (johnlea) on 2012-10-09
Changed in unity:
assignee: Jason Smith (jassmith) → nobody
Changed in unity (Ubuntu):
assignee: Jason Smith (jassmith) → nobody
John Lea (johnlea) on 2012-10-15
Changed in unity:
importance: Low → Medium
Changed in unity (Ubuntu):
importance: Low → Medium
Changed in unity:
milestone: backlog → 7.3.1
assignee: nobody → Marco Trevisan (Treviño) (3v1n0)
Changed in unity (Ubuntu):
assignee: nobody → Marco Trevisan (Treviño) (3v1n0)
Changed in unity (Ubuntu):
status: Triaged → In Progress
Changed in unity:
status: Triaged → In Progress
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package unity - 7.3.1+14.10.20140904-0ubuntu1

---------------
unity (7.3.1+14.10.20140904-0ubuntu1) utopic; urgency=low

  [ Martin Pitt ]
  * Adjust upstart dependency to upstart-bin. (LP: #1351306)

  [ Brandon Schaefer ]
  * When Show Desktop is active, it will set the tooltip icon as
    "Restore Windows". This is per workspace. So each time show_destop
    bool is updated in PluginAdapter, the Show Desktop icon will update
    its tooltip if needed. (LP: #1237132)
  * Use CONFIG instead of CACHE to store the first_run.stamp

  [ Stephen M. Webb ]
  * update the unity manpage (LP: #1059275)

  [ Andrea Azzarone ]
  * Share lockscreen password entry between screens. (LP: #1308540)

  [ Marco Trevisan (Treviño) ]
  * IconRenderer: draw count texture at proper scaling, built by
    LauncherIcon (LP: #1353070)
  * LauncherIcon: make the Icon count width depending on the text value
    width (LP: #796527)
  * Lockscreen: scale the UI elements based on current monitor scaling
    (LP: #1292218)
  * SwitcherView: set progress on icon render args (LP: #1361679)
  * SearchBar, ActionButtons, IconRenderer: include the font scaling
    when scaling textual items
 -- Ubuntu daily release <email address hidden> Thu, 04 Sep 2014 22:12:54 +0000

Changed in unity (Ubuntu):
status: In Progress → Fix Released
Changed in unity:
status: In Progress → Fix Committed
Stephen M. Webb (bregma) wrote :

Attached debdiff between trusty-updates and SRU.

Stephen M. Webb (bregma) on 2015-01-06
description: updated
Amr Ibrahim (amribrahim1987) wrote :

Please update unity from trusty-proposed and verify the fix.

Changed in unity (Ubuntu Trusty):
status: New → Fix Committed
tags: added: trusty verification-needed
tags: added: verification-done
removed: verification-needed
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package unity - 7.2.4+14.04.20141217-0ubuntu1

---------------
unity (7.2.4+14.04.20141217-0ubuntu1) trusty; urgency=medium

  [ Andrea Azzarone ]
  * Share lockscreen password between screens (lp: #1308540)
  * Allow a distinct pam config file for greeter and for lock-screen.
    (lp: #1305440)
  * Add an arrow activator in the lockscreen. (lp: #1332509)
  * Make sure GetScreenGeometry returns the correct value (lp: #1374785).
  * unmapped all windows prior to shutdown (lp: #1370017) (lp: #1375271)

  [ Brandon Schaefer ]
  * fix tooltip for the "Show Desktop / Restore Windows" icon in the Alt-Tab
    switcher (lp: #1237132)
  * Use CONFIG instead of CACHE to store the first_run.stamp (lp: #1328677)

  [ Eleni Maria Stea ]
  * LayoutSystem: make sure the exposed open windows are displayed in the
    preserved order (lp: #1349281).

  [ handsome_feng ]
  * added support for getting the distro name from /etc/os-release
    (lp: #1329584)

  [ Iain Lane ]
  * When grabbing keys, try prefixing "XF86" if the key isn't found. GNOME
    gives us unprefixed keys sometimes (lp: #1302885).

  [ Marco Trevisan (Treviño) ]
  * make the Launcher icon count badge width depend on the text value width
    and scaling (lp: #1353070) (lp: #1354498) (lp: #796527) (lp: #1066971)
    (lp: #1361713)
  * DecoratedWindow: make edges independent from borders and properly update
    them on actions change (lp: #1276177), (lp: #1299741), (lp: #1301776),
    (lp: #1324104), (lp: #1364225), (lp: #1373695)
  * Lockscreen: scale the UI elements based on current monitor scaling
    (lp: #1292218)
  * UnityScreen: when filtering out windows in spread, make sure we unscale
    them (lp: #1316265).
  * PanelMenuView: ensure that proper window tiles and buttons are shown at
    the right place (lp: #1384910) (lp: #1384958) (lp: #1385285)
  * SearchBar, ActionButtons, IconRenderer: include the font scaling when
    scaling textual items (lp: #1332947) (lp: #1361751) (lp: #1362162)
    (lp: #1362346).
  * ApplicationLauncherIcon: make sure we close the dash if DnD is accepted
    and the application window is about to be focused (lp: #1350331).
  * SwitcherView: set progress on icon render args (lp: #1361679).
  * LockScreenController: wait for the primary shield to get the grab
    before setting the session locked (lp: #1368427) (lp: #1371764).
  * added decorations to windows in non-focused workspaces (lp: #1383468)

  [ Stephen M. Webb ]
  * updated the unity(1) manpage to match the actual command (lp: #1059275)
  * bumped package version to match upstream

  [ Marco Trevisan (Treviño) ]
  * Preparing for unity 7.2.4
 -- Ubuntu daily release <email address hidden> Wed, 17 Dec 2014 20:52:10 +0000

Changed in unity (Ubuntu Trusty):
status: Fix Committed → Fix Released
status: Fix Committed → Fix Released

The verification of the Stable Release Update for unity has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

Stephen M. Webb (bregma) on 2015-02-11
Changed in unity:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers