Drag and drop a USB key into the trash should eject the USB key

Bug #764905 reported by Charline Poirier
14
This bug affects 3 people
Affects Status Importance Assigned to Milestone
Ayatana Design
Fix Released
High
John Lea
Unity
Fix Released
Medium
Andrea Azzarone
unity (Ubuntu)
Fix Released
Undecided
Andrea Azzarone

Bug Description

In testing participant dragged and dropped USB key in the trash but it didn't eject.

Desired solution:
- dragging and dropping a USB launcher icon in the trash launcher icon should eject the USB key
- after the USB key is ejected confirmation should be given to the user via a NotifyOSD notification
- the exact copy to be used in the NotifyOSD notification is "USB storage device [name of drive, e.g. "Neils USB key"] successfully ejected"

Related branches

tags: added: nattytesting
John Lea (johnlea)
tags: added: udo
Changed in ayatana-design:
assignee: nobody → John Lea (johnlea)
importance: Undecided → Medium
status: New → Fix Committed
John Lea (johnlea)
description: updated
Jason Smith (jassmith)
Changed in unity:
status: New → Triaged
importance: Undecided → Low
importance: Low → Medium
assignee: nobody → Neil J. Patel (njpatel)
milestone: none → alpha1
milestone: alpha1 → ux-backlog-1
John Lea (johnlea)
Changed in ayatana-design:
importance: Medium → High
Changed in unity (Ubuntu):
status: New → Triaged
John Lea (johnlea)
Changed in ayatana-design:
status: Fix Committed → Fix Released
Jorge Castro (jorge)
tags: added: backlog
Revision history for this message
eric (obrowny06) wrote :

I don't understand why dragging the usb key to the trash should eject it ?
The trash is used to erase files so the right behaviour should be :

Dragging the usb key to the trash proposes to format the drive.
Dragging out the usb key from the launcher should eject it.

It seems more logical to me.

Revision history for this message
Daniel Manrique (roadmr) wrote :

The reason why the user thought dragging the USB key to the trash would eject it, is probably that he has prior experience with Macintosh, where the trashcan icon ejects removable media (CDs, floppies, memory cards, USB drives).

However I agree with obrowny that this behavior per se is unintuitive and inconsistent, and it's only by residual Mac experience that the user was expecting that behavior.

Just a comment.

Revision history for this message
Andrea Azzarone (azzar1) wrote :

@John Lea: can you give me the exact text for NotifyOSD notification? And should we notify both the success and the failure?

Changed in unity:
assignee: Neil J. Patel (njpatel) → Andrea Azzarone (andyrock)
status: Triaged → In Progress
Mirco Müller (macslow)
Changed in unity:
status: In Progress → Fix Committed
Revision history for this message
John Lea (johnlea) wrote :

@Andrea Azzarone: description updated with text to be used in NotifyOSD notification. What are available failure modes? If you could list them I can write the text for the notifications.

description: updated
Revision history for this message
Julien (julienmbpe) wrote :

I don't understand the interest of this function... If i send a volume to the trash, i expect it to be erased, not to be ejected...

Is the implementation of this fonction freezed or is it just a test ?

Changed in unity (Ubuntu):
status: Triaged → Fix Committed
Gord Allott (gordallott)
Changed in unity:
milestone: none → 4.4.0
Changed in unity:
status: Fix Committed → Fix Released
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package unity - 4.4.0-0ubuntu1

---------------
unity (4.4.0-0ubuntu1) oneiric; urgency=low

  * New upstream release.
    - moving a launcher icon around generates lots of disk write activity
      (LP: #733425)
    - compiz crashed with SIGSEGV in sigc::signal_base::impl() (LP: #762801)
    - Drag and drop a USB key into the trash should eject the USB key
      (LP: #764905)
    - unity window decorator needs to support different metacity frame types
      (LP: #795048)
    - Don't switch title to menu when hovering window buttons (LP: #691808)
    - spacing between indicators should be 5 pixels (LP: #734010)
    - Dash: highlight box is mis-aligned with smaller icon (LP: #761465)
    - Merge libindicator scroll signals (LP: #804618)
    - unity: Dead code in Launcher.cpp: "mask | (Button1Mask & Button2Mask &
      Button3Mask)" (LP: #805327)
    - TrashLauncherIcon::UpdateTrashIconCb is leaking (LP: #806984)
    - Title fade effect no longer works (LP: #809907)
    - Accessibility support not initialized on Oneiric (LP: #810033)
  * debian/control:
    - build-dep on libnotify-dev
    - bump libnux-1.0-dev dep for ABI break
  * debian/rules:
    - bump libunity-core-4.0-4 shlib for ABI break
 -- Didier Roche <email address hidden> Thu, 21 Jul 2011 18:41:15 +0200

Changed in unity (Ubuntu):
status: Fix Committed → Fix Released
Revision history for this message
John Lea (johnlea) wrote :

Reverted to 'confirmed' because the d&d fails (impossible to d&d at all) when a single USB key is inserted after a fresh install of Oneirc. If two USB keys are inserted at the same time it works, and sometimes it continues to work even after both USB keys are removed and only one is re-inserted.

Changed in unity:
status: Fix Released → Confirmed
Revision history for this message
Andrea Azzarone (azzar1) wrote :

This a general problem, but for the app icons it never happens since there are always hidden app icons in launcher. Create a fake hidden launcher device icon is the simple solution. What do you think DBO?

Andrea Azzarone (azzar1)
Changed in unity:
assignee: Andrea Azzarone (andyrock) → nobody
assignee: nobody → Andrea Azzarone (andyrock)
Changed in unity (Ubuntu):
assignee: nobody → Andrea Azzarone (andyrock)
Andrea Azzarone (azzar1)
Changed in unity:
status: Confirmed → In Progress
Revision history for this message
Alan Bell (alanbell) wrote :

Should it not say "USB storage device [name of drive, e.g. "Neils USB key"] is safe to remove" because it doesn't eject USB devices and it seems silly to tell the user something has ejected when it plainly has not. Also, count me with the people who are bemused by the concept of putting a USB key in the rubbish bin and expecting it to be unmounted. I would think that would format it, if anything.

Revision history for this message
John Lea (johnlea) wrote :

@alanbell

Agreed that you do not literally eject a USB key, however we have found repeatedly in user testing that users look for a USB key 'eject' option, and are most comfortable taking about USB device removal in terms of "ejecting". This is very much a product of conditioning from using Windows, but none the less we don't gain anything from deviating from the recognised Windows conventions at this specific point.

Andrea Azzarone (azzar1)
Changed in unity:
status: In Progress → Fix Committed
Andrea Azzarone (azzar1)
Changed in unity:
status: Fix Committed → Fix Released
John Lea (johnlea)
tags: added: reviewedbydesigno
removed: udo
Revision history for this message
Alan Bell (alanbell) wrote :

this is actually stated as something that shouldn't be done in the GNOME HIG
http://developer.gnome.org/hig-book/3.0/principles-match.html.en

"On the other hand, a waste basket should not be used for anything other than holding discarded files. It should not be used, for example, to eject a removable disk such as a floppy or CD."

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.