Dash - "See more..." line should be base-aligned with section header

Reported by Mark Shuttleworth on 2011-04-02
20
This bug affects 3 people
Affects Status Importance Assigned to Milestone
Ayatana Design
Critical
John Lea
Unity
Medium
Andrea Azzarone
unity-2d
Undecided
Unassigned
unity-2d (Ubuntu)
Undecided
Unassigned
unity (Ubuntu)
Medium
Andrea Azzarone

Bug Description

The "See nnnn more..." text in the dash on each section should have the same baseline as the section name to its left. At the moment, the "See more..." piece looks a few pixels too high.

Desired solution:

- Review the "file_lens_17_08_11_02.png" visual design that is attached to this bug. This design shows the expanded and collapsed states of both the Dash category headers and search filter sections, and also the exact desired positioning and alignment (basically the "See more... text is baselined, and the expand/contract arrows are always centred relative to the directly proceeding text).

- Adjust size/position of dash elements until they exactly match the design. This can be tested by overlaying the attached design with some opacity on top of a screenshot of the dash in GIMP.

Related branches

lp:~macslow/unity/unity.fix-748101
Merged into lp:unity at revision 1774
Sam Spilsbury (community): Approve (style) on 2011-12-12
lp:~andyrock/unity/fix-748101
Merged into lp:unity at revision 2096
Alex Launi (community): Approve on 2012-03-07
Marco Trevisan (Treviño): Approve on 2012-02-29
Thomi Richards: Approve on 2012-02-29
Andrea Cimitan: Approve (design) on 2012-02-29
Mark Shuttleworth (sabdfl) wrote :

Attachment shows the specific scene of the crime.

Changed in unity:
status: New → Confirmed
Changed in unity (Ubuntu):
importance: Undecided → Low
status: New → Triaged
Changed in unity:
assignee: nobody → Marco Biscaro (marcobiscaro2112)
Changed in unity (Ubuntu):
status: Triaged → In Progress
Changed in unity:
status: Confirmed → In Progress

Initial problem: the extend text is not base-aligned to section name.

What happens: the icon on left, the section name, the extend label and the extend icon are vertically centered (see middle.png).

The proposed change: all cited itens should be bottom aligned.

Other problem: the extend icon on right has dimension of 24x24 pixels and it will seems too high (see bottom.png).

Proposed solution: resize the icon to 12x12 pixels (see bottom-resized.png).

The solution above was applied and the initial problem was solved (see result.png and result2.png).

The new problem: when the section has no expand text (like the Shortcuts section on dash's main screen), the expand icon will seems too low (see problem.png and problem2.png).

Proposed solution:

1. Does not allow the Shortcuts section to be expanded/contrated
2. Does not change the current layout: leaves the texts and icons vertically centered
3. Add an expand text on Shortcuts section
4. Hack dash to center the expand icon if no expand text is defined

What do you think?

Thanks Marco.

I'm putting this bug on this week's radar and will let you iterate with Design/Mark on the best layout solution.

Changed in unity:
importance: Undecided → Low
milestone: none → 3.8.4
Florian Boucault (fboucault) wrote :

"See nnnn more..." text in the dash on each section already has the same baseline as the section name to its left in Unity 2D.
Please advise the Unity 2D team of any other UI change.

Changed in unity-2d:
status: New → Fix Released

I need a feedback of which of the proposed solutions (or maybe another solution that was not proposed yet) will fit best on this case.

Changed in unity:
status: In Progress → Incomplete
Changed in unity (Ubuntu):
status: In Progress → Incomplete

Hi Marco

Thanks again for the exploration of options. I think base-align
everything, resize to 12x12 triangle as you suggest, *except* that when
there is no "small middle text" I would center align the triangle on the
larger text.

Put differently:

 * base-align the image, large text, and small text
 * center the swivel-triangle (reduced to 12x12) on the base-to-x-height
of whatever text precedes it, whether that is larger text or smaller text.

Make sense?

To be honest I don't really understand the descriptions of the solutions. A picture would really enlighten me.

I attach a screenshot of Unity 2D for your consideration and approval/disapproval. Please ignore the fact that the fonts are bold (that is bug #741862).
This layout is what had been shown and discussed back in December with Mark and corresponds to the mockups created by Otto (visual designer).

The screenshot is +1 for Natty. Please create a visual design task for
Otto to specify:

 - the relationship between the icon and group header
 - the relationship between group header and the smaller text
 - the relationship between the swivel triangle and prior text

On looking at the picture again, I would restate my suggestion as
follows. First, some terminology. By "baseline" I mean the bottom of
letters like m and x. By x-height I mean the top of lowercase x. By
"centered" I mean "the middle of the image" or "the middle of the
baseline-to-x-height for text.

The image and group header should be aligned centered. The Group header
and subsequent small text should be baseline aligned. The final swivel
triangle should be center-aligned with the preceding text (which would
be different if there was no small text, only the big group header).

Mark

Didier Roche (didrocks) on 2011-04-07
Changed in unity:
milestone: 3.8.4 → 3.8.6
Didier Roche (didrocks) on 2011-04-11
Changed in unity:
milestone: 3.8.6 → 3.8.8
Didier Roche (didrocks) on 2011-04-14
Changed in unity:
milestone: 3.8.8 → 3.8.10
David Barth (dbarth) on 2011-04-18
Changed in unity:
milestone: 3.8.10 → 3.8.12

Unity 2D is using Qt (if I'm not mistaken) to manage the dash's layout.

I think (at least from what I've researched so far) that Nux can't handle complex layouts (at moment, it's using a HLayout, that can only use TOP, MIDDLE or BOTTOM positions - that affects all components on layout).

There are some Nux class that can handle this kind of layout? Or maybe we need to use nested layouts?

If I'm wrong, please, someone give the right direction.

David Barth (dbarth) on 2011-04-22
Changed in unity:
milestone: 3.8.12 → backlog
Didier Roche (didrocks) on 2011-04-22
Changed in unity:
assignee: Marco Biscaro (marcobiscaro2112) → nobody
John Lea (johnlea) wrote :
description: updated
tags: added: udo
Changed in ayatana-design:
assignee: nobody → John Lea (johnlea)
importance: Undecided → High
status: New → Fix Committed
Changed in unity:
status: Incomplete → Confirmed
Changed in unity (Ubuntu):
status: Incomplete → Confirmed
Didier Roche (didrocks) on 2011-10-14
Changed in unity-2d (Ubuntu):
status: New → Fix Released
John Lea (johnlea) on 2011-10-18
Changed in ayatana-design:
status: Fix Committed → Triaged
tags: added: udp
Mirco Müller (macslow) wrote :

I've sat down with John and also looked at the provided explanation-images from Marco. So we'll know how to fix this.

Changed in unity:
assignee: nobody → Mirco Müller (macslow)
John Lea (johnlea) on 2011-11-01
Changed in ayatana-design:
status: Triaged → Fix Committed

Nice! :)

tags: added: unity3p
Mirco Müller (macslow) on 2011-12-07
Changed in unity:
status: Confirmed → In Progress
Mirco Müller (macslow) wrote :

I need the correct expanded and unexpanded arrows. The artwork-assets we have are 24x24 each and actually the wrong shape. Looking at the mockups it's a more pointy triangle with the size of 5x7 and 7x5 without any glow. The base-line alignment fixes are done.

Xi Zhu (xi.zhu) wrote :
Xi Zhu (xi.zhu) wrote :

the arrows should be in 50% opacity :)

Mirco Müller (macslow) wrote :

Thanks Rosie for the updated assets. I just had to crop them down to 9x9 so they don't mess up the layout in nux/unity.

Here as a comparison see the state before the fix...

  http://people.canonical.com/~mmueller/748101-before.png

... and after the fix...

  http://people.canonical.com/~mmueller/748101-after.png

Omer Akram (om26er) on 2011-12-09
Changed in unity (Ubuntu):
status: Confirmed → In Progress
Mirco Müller (macslow) on 2011-12-13
Changed in unity:
status: In Progress → Fix Committed
Omer Akram (om26er) on 2011-12-13
Changed in unity (Ubuntu):
status: In Progress → Fix Committed
Changed in unity:
milestone: backlog → 5.0.0
Andrea Cimitan (cimi) on 2011-12-13
summary: - "See more..." line should be base-aligned with section header in Dash
+ Dash - "See more..." line should be base-aligned with section header
Didier Roche (didrocks) on 2012-01-12
Changed in unity:
status: Fix Committed → Fix Released
Launchpad Janitor (janitor) wrote :
Download full text (6.0 KiB)

This bug was fixed in the package unity - 5.0.0-0ubuntu1

---------------
unity (5.0.0-0ubuntu1) precise; urgency=low

  [ Didier Roche ]
  * New upstream release.
    - compiz crashed with SIGSEGV in __dynamic_cast() (LP: #853038)
    - unity-panel-service crashed with SIGSEGV in panel_service_show_entry()
      (LP: #861144)
    - unity-panel-service crashed with SIGSEGV in
      panel_indicator_entry_accessible_get_n_children() (LP: #869816)
    - Launcher - Launcher icon for Dash does not highlight when the Alt+F1 key
      shortcut is pressed (LP: #849561)
    - compiz crashed with SIGSEGV in unity::PanelTray::FilterTrayCallback()
      (LP: #868868)
    - [regression] Compiz: Visible tearing is worse in 11.10 than 11.04, even
      when "Sync To VBlank" is enabled, but only when Unity is active.
      (LP: #880707)
    - [regression] All apps have a lower frame rate under Unity. (LP: #861061)
    - compiz crashed with SIGSEGV in
      nux::Property<nux::color::Color>::operator=() from
      unity::switcher::SwitcherController::OnBackgroundUpdate() (LP: #887465)
    - DashSearchBarSpinner.cpp:56: Conditional jump or move depends on
      uninitialised value(s) (LP: #901610)
    - quicklist shows in incorrect position when launched from workspace
      switcher (LP: #914251)
    - Build "show me the desktop" mini-app that adds a show desktop button to
      Launcher (LP: #681348)
    - Select quicklist items with just one right click (LP: #688830)
    - cannot change volume by scrolling on the icon when the SoundMenu is
      opened (LP: #722082)
    - [a11y] Unity launcher buttons are not Actionable (LP: #772573)
    - Ubuntu Start launcher item doesn't start dash with keyboard navigation
      (LP: #825037)
    - multimonitor , window management - Multi-Monitor Maximized Difficulty
      (LP: #843958)
    - [regression] Drag and drop inside dash is very slow with Active Blur
      activated (LP: #851172)
    - Activating an alt-tab icon that holds initially unminimized windows
      should unminimize all windows (LP: #854595)
    - Dash - The Dash category headers are positioned incorrectly
      (LP: #839467)
    - Missing global menu with a semi-maximized window dragged to the right.
      (LP: #861279)
    - Launcher - Dragging and dropping a running application in to the Trash
      should quit the application and (if the app is pinned to the Launcher)
      un-pin the application from the Launcher (LP: #870143)
    - top bar, integrated menu - when a application is first launched, the
      integrated menu should be displayed for 2 seconds before fading out of
      view (LP: #874254)
    - Window control buttons are not shown when an indicator is opened and the
      pointer is over the top-left corner (LP: #890970)
    - Quicklist item using some special chars doesn't show at all
      (LP: #899677)
    - PanelView.cpp:370: Conditional jump or move depends on uninitialised
      value(s) (LP: #901602)
    - unityshell.cpp:1982,1984: Conditional jump or move depends on
      uninitialised value(s) (LP: #901603)
    - Dash Search spinner sometimes doesn't spin at all (LP: #903090)
    - Point of tooltip is misaligned to focused ap...

Read more...

Changed in unity (Ubuntu):
status: Fix Committed → Fix Released
Andrea Cimitan (cimi) wrote :

Bug present in unity trunk.

Changed in unity:
status: Fix Released → Triaged
milestone: 5.0.0 → 5.4.0
Omer Akram (om26er) on 2012-01-31
Changed in unity (Ubuntu):
status: Fix Released → Triaged
Didier Roche (didrocks) on 2012-02-17
Changed in unity:
milestone: 5.4.0 → 5.6.0
Andrea Cimitan (cimi) on 2012-02-17
tags: added: top5p
Mirco Müller (macslow) on 2012-02-20
Changed in unity:
status: Triaged → In Progress
Mirco Müller (macslow) wrote :

As of unity trunk (r1987) this bug remains being fixed. There is no regression!

See:
http://people.canonical.com/~mmueller/fix-748101-1.png
http://people.canonical.com/~mmueller/fix-748101-2.png

Changed in unity:
status: In Progress → Fix Committed
John Lea (johnlea) on 2012-02-20
Changed in ayatana-design:
importance: High → Critical
Andrea Cimitan (cimi) wrote :

Mirco, yous screenshot seems fine, but on my system (bzr2002), the regression is here.

Changed in unity:
status: Fix Committed → Confirmed
Omer Akram (om26er) on 2012-02-22
Changed in unity:
importance: Low → Medium
status: Confirmed → Triaged
Changed in unity (Ubuntu):
importance: Low → Medium
Omer Akram (om26er) wrote :

me to I am using latest trunk and still have this.

Mirco Müller (macslow) wrote :

Can everybody who sees this still, report what _real_ screen-DPI and system font-size they are using. For the DPI use:

xdpyinfo | grep dimensions

For the set system font-size use:

gsettings get org.gnome.desktop.interface font-name

Changed in unity:
assignee: Mirco Müller (macslow) → Andrea Azzarone (andyrock)
Changed in unity (Ubuntu):
assignee: nobody → Andrea Azzarone (andyrock)
Changed in unity:
status: Triaged → In Progress
Changed in unity (Ubuntu):
status: Triaged → In Progress
Didier Roche (didrocks) on 2012-03-12
Changed in unity:
milestone: 5.6.0 → 5.8.0
Changed in unity:
status: In Progress → Fix Committed
Changed in unity (Ubuntu):
status: In Progress → Fix Committed
Didier Roche (didrocks) on 2012-03-23
Changed in unity:
status: Fix Committed → Fix Released
Launchpad Janitor (janitor) wrote :
Download full text (5.4 KiB)

This bug was fixed in the package unity - 5.8.0-0ubuntu1

---------------
unity (5.8.0-0ubuntu1) precise-proposed; urgency=low

  * New upstream release.
    - New "push mouse offscreen" feature really difficult to get (LP: #923749)
    - unity-2d-panel crashed with SIGSEGV in
      unity::indicator::DBusIndicators::Impl::RequestSyncAll() (LP: #864737)
    - Pressing "Alt+Enter" causes compiz to crash in CompOption::value() from
      unity::UnityScreen::showLauncherKeyTerminate (LP: #960957)
    - SEGSIGV after unplugging external monitor (LP: #962693)
    - Background colorization should use a different heuristic (LP: #865239)
    - compiz+unity3d generates > 50 wakeups a second on idle system
      (LP: #917210)
    - [FFe, UIFe] HUD - The HUD does not respect launcher autohide or icon
      size settings (LP: #921506)
    - clicking on folders in the file lens does not open nautilus
      (LP: #921665)
    - No text inside multirange filters (LP: #927710)
    - can't alt-tab restore minimized uis which have an instance on another
      workspace (LP: #933397)
    - Ubuntu Software Center Unity launcher integration is not working
      (LP: #932280)
    - The line separator between the launcher and the dash is cleared when
      selecting a category (LP: #941082)
    - unity-panel-service crashed with SIGSEGV in g_hash_table_foreach()
      (LP: #937119)
    - Alt-F10 locks up Unity (LP: #948522)
    - multimonitor, launcher: Provide an option to display either a single
      launcher or a launcher on each display in a multi-monitor environment
      (LP: #950136)
    - multimonitor: Please give me a way to turn off sticky monitor edges
      (LP: #946104)
    - Unity 5.6: key bindings (such as Super) don't work on empty workspace or
      on slow/loaded systems (LP: #953089)
    - Alt+arrows keyboard shortcuts don't invoke Back and Forward navigation
      (LP: #953783)
    - HUD is sending 2 menu signals instead of 1 (LP: #956878)
    - 6th item of HUD not fully visible (LP: #957229)
    - HUD: seems to trigger operations more than once (LP: #960503)
    - Launcher gets always desaturated when using HUD on secondary monitor
      (LP: #961169)
    - [5.8 pre staging] launcher is displayed on the left screen, not the
      primary one (LP: #961281)
    - launcher icons do not re-saturate after dash is closed (LP: #961844)
    - Launcher shows arrows for applications on all workspaces (LP: #961977)
    - Dash - Implement overlay scrollbars in Dash (LP: #608124)
    - [UIFe] Dash - No message displayed when no results are returned in the
      Dash (LP: #711199)
    - Dash - "See more..." line should be base-aligned with section header
      (LP: #748101)
    - Dash - Missing category separator line in dash (LP: #850984)
    - Dash and Launcher - As soon as a user starts dragging a file from the
      Dash, there is a 'flicker' before the Launcher icons that are valid drop
      receptacles re-saturate (LP: #863230)
    - Dash - When multiple results have equal string match relevancy ranking,
      those with equal ranking should be then sorted by frequency of use.
      (LP: #871900)
    - Keyboard shortcut - F10 shortcut is used to show m...

Read more...

Changed in unity (Ubuntu):
status: Fix Committed → Fix Released
Tim Penhey (thumper) on 2012-04-16
Changed in ayatana-design:
status: Fix Committed → Fix Released
John Lea (johnlea) on 2012-04-16
Changed in ayatana-design:
status: Fix Released → Fix Committed
Nick Tait (jnick-tait) on 2012-04-20
tags: added: reviewedbydesignp
Changed in ayatana-design:
status: Fix Committed → Fix Released
Nick Tait (jnick-tait) on 2012-04-20
tags: removed: udo udp
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Duplicates of this bug

Other bug subscribers