quicklist must respect enabled state

Bug #731533 reported by Marco Biscaro on 2011-03-08
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Unity
Fix Released
Undecided
Marco Biscaro
unity (Ubuntu)
Undecided
Unassigned

Bug Description

When a QuickListMenuItem is with the enabled state defined as false, QuicklistView must not hide or send the clicked signal of QuickListMenuItem on mouse click.

Example: on bug #723880, the option "Empty trash" should exist, even when the trash is already empty. In that case, the QuickListMenuItem must be disabled.

What happens:
Even disabled, when I click on "Empty trash", the quicklist is closed and a 'clicked' signal is emited.

Expected behaviour:
When I click on a disabled menu item, nothing should happens (neither the quicklist close, nor the 'clicked' signal is emited).

Related branches

Related bugs: bug #723880 and bug #676928

Alex Launi (alexlauni) wrote :

Could you please elaborate on why you filed this bug, what you're trying to say, and how it relates to those other bugs?

Changed in unity:
status: New → Incomplete
Changed in unity (Ubuntu):
status: New → Incomplete

@Alex: I've updated the description to better explain the problem.

description: updated
Changed in unity:
status: Incomplete → New
Changed in unity (Ubuntu):
status: Incomplete → New
Alex Launi (alexlauni) wrote :

I still don't see how this is a bug, when in the current Unity right clicking an empty trash shows no quicklist. Is this some kind of "keep this under consideration" wishlist bug?

Changed in unity (Ubuntu):
status: New → Incomplete
Changed in unity:
status: New → Incomplete

@Alex: is a consistency bug. When you try to click on a disabled button, I don't expect that it send a clicked signal (since it was not actually clicked, it was disabled!).

The trash has no "Empty trash" yet, but there is a branch linked to solve it. *But*, when that bug is solved, this one will be a problem.

Anyway, when looking to it, I realized that it is a very simple bug. I'm linking a branch.

Changed in unity:
status: Incomplete → New
Changed in unity (Ubuntu):
status: Incomplete → New
Alex Launi (alexlauni) wrote :

Next time just comment on the merge proposal, rather than filing a bug on a feature that hasn't landed yet.

Changed in unity:
status: New → Triaged
Changed in unity (Ubuntu):
status: New → Triaged
Changed in unity:
status: Triaged → In Progress
Changed in unity (Ubuntu):
status: Triaged → In Progress
Changed in unity:
assignee: nobody → Marco Biscaro (marcobiscaro2112)
Neil J. Patel (njpatel) on 2011-03-10
Changed in unity:
status: In Progress → Fix Committed
Changed in unity (Ubuntu):
status: In Progress → Fix Committed
Changed in unity:
milestone: none → 3.6.4
Didier Roche (didrocks) on 2011-03-10
Changed in unity:
status: Fix Committed → Fix Released
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package unity - 3.6.4-0ubuntu1

---------------
unity (3.6.4-0ubuntu1) natty; urgency=low

  * New upstream release.
    - Unity: Alt-F2 not working (LP: #580295)
    - When running with dual monitors, Unity will use the height of the larger
      one for calculating when to fold (LP: #696388)
    - Unity app launcher is filled up with doublettes (LP: #690537)
    - Unity interface not resized properly when external monitor is used
      (LP: #691772)
    - Dash needs keyboard navigation (LP: #727714)
    - It is possible to focus Unity itself and Close it from the global menu
      (LP: #728790)
    - Systray icons showing on top of everything (LP: #728719)
    - Pressing ENTER in the dash during a search should open the first
      displayed item (LP: #729699)
    - compiz crashed with SIGSEGV in LauncherIcon::OpenQuicklist()
      (LP: #731096)
    - inactive menus are not shown (LP: #732162)
    - Icon-only menu titles don't have accessible names (LP: #691677)
    - unity not working on rotated displays (LP: #694596)
    - unity_support_test crashed with SIGSEGV in
      nux::IOpenGLAsmVertexShader::IOpenGLAsmVertexShader() (LP: #709649)
    - Dragging .desktop file to launcher's trash creates space for new
      launcher icon (LP: #717250)
    - Unable to scroll in Applications/Files and Folders Place using mouse
      wheel (LP: #721447)
    - The applications place is empty (LP: #724259)
    - compiz crashed with SIGSEGV in
      nux::GpuRenderStates::SubmitChangeStates() (LP: #719156)
    - Quicklists are difficult to dismiss (LP: #726890)
    - Apps in Available group not rendered in Dash (LP: #729710)
    - Clicking on Shortcuts header doesn't do anything. (LP: #730774)
    - Zeitgeist FTS Extension doesn't filter on subject URIs (LP: #731208)
    - dual monitor,,,upper panel turns white / nvidia (LP: #685179)
    - Dash file Lens – Rename “Favourite Folders” category header to “Folders”
      (LP: #723866)
    - looking for 'places' icons in the wrong location (LP: #727672)
    - Empty trash quicklist item is missing an ellipsis (LP: #731472)
    - Wastebasket quicklist is missing “Empty Wastebasket” option when the
      wastebasket is empty (LP: #723880)
    - Emptying the trash from the unity sidebar should respect nautilus' "Ask
      before emptying" setting (LP: #730003)
    - start-here icon updated at wrong time (LP: #726267)
    - Unity overlay unhide issue (LP: #726926)
    - Orca doesn't report that the Launcher receives the focus (LP: #727133)
    - Accessibility object parent-child hierarchy on unity is broken
      (LP: #727908)
    - Regression: Orca doesn't speech out the selection changes on the
      Launcher (LP: #729165)
    - quicklist must respect enabled state (LP: #731533)
    - unity-panel-service crashed with SIGSEGV in
      dbusmenu_menuitem_send_about_to_show() (LP: #725631)
  * debian/control:
    - build-dep on latest nux
 -- Didier Roche <email address hidden> Thu, 10 Mar 2011 19:52:53 +0100

Changed in unity (Ubuntu):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers