Launcher - clicking trash or device icons multiple times opens multiple instances

[Kyle Clarke]

When you click on the trash icon multiple times, it will keep opening new windows.

Instead it should bring the open window to focus. I can not think of any circumstances where two trash windows are necessary. But in case it ever is, a "Open new window" entry should be in it's quicklist.

---------------------------------------
Desired Solution:

- If a 'trash' Nautilus window is already open, clicking on the Trash Launcher icon should focus the already open Nautilus window that is currently displaying the trash

- However 'window open' or 'running' triangles *should not* be displayed (on either side of the Trash icon)

[Mark Shuttleworth (sabdfl)]

 status confirmed

The Trash window should be re-focused by default, and yes, a quicklist
item for "Open the Rubbish Bin again" would be good.

Mark

[David Barth (dbarth)]

Assigning to Jason by default, but the bug is still up for grab as a bitesize one.

[Carl Simpson (cwd-simpson)]

If you have a trash window open, and it is already focussed, you might not notice- especially if you have a lot of Nautilus windows open at once (or you are just being scatterbrained, which it is so easy to be when handling a lot of information on a computer).

The proposed plan would mean that the trash button does nothing if the trash window is already in focus. You wouldn't think pressing the button had done anything at all, and might think that it is broken, for a moment. Maybe pressing the button could also highlight the window in some way? (But only when the window is already in focus?)

It seems bad for a piece of interface to on occasion do nothing whatsoever.

[Cameron Hart (bitshifternz)]

Also if you open a trash window by clicking on the trash icon, what happens if the user navigates away from the trash folder in nautilus? Is is still a trash window at this point or a nautilus window? Should it raise the original window that was opened or a new one? Or does it raise any Nautilius window that is browsing the trash folder at the time?

It seems like something that could lead to quite inconsistent behaviour from a user perspective.

[Wade Pedersen (wmpedersen)]

@Cameron Perhaps I don't understand your meaning, but Trash always opens in the Nautilus launcher, and does not provide an indicator under Trash.

[Balassa Máté (balassa-mm)]

What should happen if there are multiple instances open of the same trash/rubbish bin? Wich one will get the focus? This can be a source of other bugs...

On the other hand I've got to agree, it is much more user friendly if it is like imagined in the report...

[Balassa Máté (balassa-mm)]

This was marked as a bitsize bug so while trying to help unity I'm trying to do something not so important...
I can not guarantee that I'm doing the right thing, this is my first try.

[Marco Biscaro (marcobiscaro2112)]

@Florian: delta-with-3d? But both Unity 2D and Unity 3D are affected by this bug.

[Florian Boucault (fboucault)]

@Marco: I know but it seems there is a branch ready to land in Unity 3D that will fix the issue. I am planning ahead :)

[Richard Dale (rdale)]

I've been looking into this, and at the moment the trash file manager is launched with a g_app_info_launch_default_for_uri(TRASH_URI, NULL, &error) call. I don't think it is possible to detect whether or not a handler for the 'trash://' uri has already been launched. So it just starts up a new nautilus window every time.

A possible work round would be to simply have a desktop file called 'trash.desktop' with the trashcan icon, that had a line in it 'Exec: nautilus 'trash://'. That way the application would only be launched once as it would be just a normal app icon rather than something special cased.

[Olivier Tilloy (osomon)]

Interesting suggestion Richard! However, for it to be really portable the desktop file should not invoke nautilus directly (the user may have another file manager of choice), but rather xdg-open. `xdg-open trash://` should just do the right thing. Alas, I seriously doubt the launcher, through bamf, will be able to match whatever window opens as a result to the trash. It would be worth a try though, there may be an elegant solution to this problem that I’m overlooking.

Also note how the implementation proposed by Stefano for unity addresses the problem (have a look at the pending merge request, it contains detailed explanations). It does have a weak point, but it’s an original way of tackling the problem, you may be able to get inspiration from it and perfect it ;)

[David Barth (dbarth)]

The workaround doesn't feel safe to land in an SRU anymore. I'd rather have the logic of that go outside of the window manager, where it can be stabilized without risking the whole rest of the process.

[Marco Biscaro (marcobiscaro2112)]

The proposed branch was not merged with trunk. Reverting to Confirmed.

[Victor Martinez (victored)]

I think that implementing a Trash Place would be a better solution to this bug.

[Launchpad Janitor (janitor)]

Status changed to 'Confirmed' because the bug affects multiple users.

[Stephen M. Webb (bregma)]

Evidently this was fixed in Unity-2D some time ago but not properly marked in the release.

[Launchpad Janitor (janitor)]

This bug was fixed in the package nautilus - 1:3.6.3-0ubuntu9

---------------
nautilus (1:3.6.3-0ubuntu9) raring; urgency=low

  * Renamed patches coming from the upstream vcs to be prefixed with git_
  * debian/nautilus-home.desktop:
    - use --new-window in that desktop as well

  [ Marco Trevisan (Treviño) ]
  * debian/patches/10_reuse_already_opened_views.patch
    - Try to reuse the available windows or tabs when opening an already opened
      location (lp: #692444)
  * debian/patches/12_unity_launcher_support.patch:
    - Quicklist entries to show the copy dialog should use a separator (lp: #1154109)
    - Transfer dialog should be presented using the correct timestamp (lp: #1154111)
    - Use the quicklist activation timestamp to set the application user time
      so that the opened windows will be focused (lp: #1154237)
  * debian/patches/17_static_unity_quicklist.patch:
    - Use nautilus --new-window to open a New window
  * debian/patches/19_add_desktop_keywords.patch:
    - Adding .desktop files keywords from upstream
  * debian/patches/20_export_opened_locations_on_dbus.patch:
    - Export the opened locations to dbus (lp: #1063830)
 -- Sebastien Bacher <email address hidden> Thu, 14 Mar 2013 11:23:18 +0100