unity crashes if a place is opened with the super-short-key

[Omer Akram]

if you try to switch to places, trash or workspaces with super key combination unity crashes.

[Vadim Rutkovsky (roignac)]

I was able to reproduce this in Unity 0.2.34

[Didier Roche-Tolomelli (didrocks)]

even happens with trunk, I get a lot of
"(mutter:25495): dee-WARNING **: Unable to connect to peer (:1.482): Could not get owner of name ':1.482': no such name" and then crash

[Mikkel Kamstrup Erlandsen (kamstrup)]

The same thing happens id you activate a workspace this way - there is another bug reported on this.

Milestoned for next week.

[Mirco Müller (macslow)]

Omer, which key-combination did you try when unity crashed?

[Omer Akram (om26er)]

to reproduce you should have a little less apps pinned to the launcher so that when super key is pressed one of the overlay comes on any special tile. so when you try to switch to any special tile it crashes.

[Erlan Sergaziev (sergeant)]

In my case, it crashes when either - <Logo + A> or <Logo + 7> are pressed. 7 because the workspaces is 7th from top and it is indicated when I click and hold <Logo> = <Windows> key.

[Adam Guthrie (therigu)]

In mine, super + spacebar

[Iain Buclaw (iainb)]

In mine, super + alt

[Iain Buclaw (iainb)]

Adding debug session of running unity (via mutter).

Any more info needed, just ask. Regards.

[Iain Buclaw (iainb)]

Function:

private void on_super_key_modifier_release (uint keycode)
{
  if (!Unity.global_shell.super_key_active) return;
  int index = (int)keycode - 10;
  index = int.min (index, model.size - 1);
  if (index < 0 || index > 9) return;

  Unity.global_shell.super_key_active = false;

  var childcontroller = get_controller_for_view (model[index]);
  childcontroller.activate ();
}

I'm not really the one to say, but would this be sufficient in fixing, or is the problem deeper than what my 5 minute conclusion comes to agree with? :-)

   var childcontroller = get_controller_for_view (model[index]);
- childcontroller.activate ();
+ if (childcontroller != null)
+ {
+ childcontroller.activate ();
+ }

Regards

[David Barth (dbarth)]

Mirco, please test the fix provided by Iain.

[Mirco Müller (macslow)]

I'll take a look at Iain's patch.

[Mirco Müller (macslow)]

Iain's patch fixes the crash itself. Sofar so good. But for all places (Trash, Files&Folders, Workspaces, Favourites) get_controller_for_view(model[index]) returns NULL. Other launchers do work though. Looking into the issue with get_controller_for_view() now.

Should we keep that in this bug or open a new one for it?

[Colin Watson (cjwatson)]

unity (0.2.38-0ubuntu1) maverick; urgency=low

  * New upstream release:
    - Correct the offset of the quicklist so it doesn't jump to the right when
      expanding from a tooltip. Fixes (LP: #631446)
    - Log apps launched via unity-place-application (LP: #632203)
    - Fix launcher does not contract if a menu is open (LP: #631452)
    - Auto scroll speed is now corrected (LP: #633045)
    - Removes jittering when rubber band is in use on the launcher (LP: #632991)
    - Fix clicking on the right of the divider also triggers action on logo
      (LP: #636602)
    - Full i18n support (LP: #637128)
    - Avoids the crash on Super-key-shortcuts with places. (LP: #632460)
    - Pressing enter in search mode should activate the first result
      (LP: #620945)
    - Esc close the places view (LP: #599891)
    - Launcher shouldn't 'fold' when hovering on a quicklist (LP: #632079)
  * update debian/libunity0.symbols

 -- Didier Roche <email address hidden> Tue, 14 Sep 2010 20:11:57 +0200