Dash control buttons (close, maximize) do not update on state change

Bug #1461618 reported by Marco Trevisan (Treviño) on 2015-06-03
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Unity
Fix Released
Low
Marco Trevisan (Treviño)
7.2
Fix Committed
Low
Marco Trevisan (Treviño)
unity (Ubuntu)
Low
Marco Trevisan (Treviño)
Trusty
Low
Unassigned

Bug Description

Dash control buttons should update according to the state when the mouse is hovering or pressing the button.
i.e.:

[Test Case]
 0) Open the dash
 1) hover the close button
 2) the button pixmap should change to match the prelight state
 3) press (and keep it pressed) the close button
 4) the button pixmap should change to match the pressed state

[Regression Potential]
None

Related branches

Changed in unity (Ubuntu):
status: New → In Progress
assignee: nobody → Marco Trevisan (Treviño) (3v1n0)
importance: Undecided → Low
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package unity - 7.3.2+15.10.20150627.1-0ubuntu1

---------------
unity (7.3.2+15.10.20150627.1-0ubuntu1) wily; urgency=medium

  [ Andrea Azzarone <email address hidden> ]
  * Fix a regression with urgent icons not showing up if launcher is
    hidden. (LP: #1450991)
  * Make sure new icons are added to the model before calling
    SortAndUpdate. (LP: #1458950)
  * This likely could fix
    https://bugs.launchpad.net/ubuntu/+source/unity/+bug/1451613. At
    least the backtraces posted there suggest this. But I think that
    those backtraces are just leftovers of old crashes-on-unloading.

  [ CI Train Bot ]
  * New rebuild forced.

  [ Chris Townsend ]
  * Allow mouse clicks that are not in the visible area of the Quicklist
    to pass through down to the Launcher icon. Fixes a failing AP test.
    (LP: #1456245)

  [ Luke Yelavich ]
  * Implement filter results controls accessibility (LP: #1457071)

  [ Marco Trevisan (Treviño) ]
  * ApplicationManager: add missing features, keep a copy of views
    around
  * DecorationsForceQuitDialog: remove deprecated override style
    functions, use CSS
  * GnomeSessionManager: Request ScreenSaver (de)activation on VT
    changes (LP: #1405349)
  * OverlayWindowButtons: trigger a queuedraw also when a child requires
    a redraw (LP: #1461618)
  * PanelMenuView: connect to target window / application title changes
    (LP: #1418449)

 -- CI Train Bot <email address hidden> Sat, 27 Jun 2015 04:44:56 +0000

Changed in unity (Ubuntu):
status: In Progress → Fix Released
Changed in unity:
status: In Progress → Fix Committed
Andrea Azzarone (azzar1) on 2015-10-23
description: updated
description: updated
Changed in unity:
status: Fix Committed → Fix Released

Hello Marco, or anyone else affected,

Accepted unity into trusty-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/unity/7.2.6+14.04.20151021-0ubuntu1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in unity (Ubuntu Trusty):
status: New → Fix Committed
tags: added: verification-needed
Changed in unity (Ubuntu Trusty):
importance: Undecided → Low

Installed on 𝐔𝐛𝐮𝐧𝐭𝐮 𝟏𝟒.𝟎𝟒𝐋𝐓𝐒 "Trusty" all 3 patched 𝐔𝐧𝐢𝐭𝐲 𝟕 version 7.2.6+14.04.20151021-0ubuntu1 packages:

unity
unity-services
libunity-core-6.0-9

from the 𝒑𝒓𝒐𝒑𝒐𝒔𝒆𝒅 repo. Tested and verified that the close and maximize/restore buttons on Dash now shows prelight on hover and pressed state on pressing. This was one of those minor bugs that always annoyed me. Glad to have it finally fixed! 😊

The minimize button is still inactive and serves no purpose in Unity Dash, but I think it's placed there intentionally to be consistent with maximized window buttons on Unity panel.

tags: added: verification-done
removed: verification-needed
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package unity - 7.2.6+14.04.20151021-0ubuntu1

---------------
unity (7.2.6+14.04.20151021-0ubuntu1) trusty; urgency=medium

  * New upstream release

  [ Andrea Azzarone ]
  * Merge patch from https://launchpadlibrarian.net/216276242/low-gfx-
    override.patch (LP: #1491913)
  * Properly hide decorations when on "Show Desktop" mode. (LP: #1485073)
  * Do not handle events coming from viewports not actually containing the window.
    (LP: #1449654)
  * Make sure new icons are added to the model before calling SortAndUpdate
    (LP: #1458950)
  * GnomeSessionManager: Do not allow shutdown when screen is locked. (LP: #1460626)
  * GnomeSessionManager: Do not allow shutdown when screen is locked.

  [ Chris Townsend ]
  * When looking for the top-most valid window in a VP, also check if the window
    is focused if the window is set to Always on Top. This allows Launcher icon
    spread to work properly when a window is minimized an Always on Top exists in
    the group. (LP: #1131385)
  * Wait on Spread to be terminated before showing the Quicklist. (LP: #1441626)
  * If dragging an application:// uri type from the Dash to the desktop, change it
    to a file:// uri type so Nautilus can understand the type a make a copy of it
    on the desktop. (LP: #1241972)
  * Enable real page up/page down key navigation in the Dash. When using these
    keys the view scrolls the length of the visible view. (LP: #913612)
  * Save the active window when showing the Hud so the correct window is focused
    when hiding the Hud. Fixes issue when "Always on Top" windows are present.
    (LP: #1366583)
  * Save the active window when showing the Dash so the correct window is focused
    when hiding the Dash. Fixes issue when "Always on Top" windows are present.
    (LP: #1446634)
  * When using keyboard navigation in the Dash, skip category headers that are not
    expandable. Also, do not highlight the category header when the mouse cursor
    is over it. (LP: #1045933)
  * Also use the Compiz show() method when forcing an unmapped window to be
    visible when clicking on it's active Launcher icon. (LP: #989588)
  * Add option to enable and disable Unity low graphics mode on the fly in ccsm or
    via gsettings. (LP: #1412937)
  * UScreen, PanelService: get monitor at position, ignoring pre-
    multipled Gdk scale factor (LP: #1351591)

  [ Marco Trevisan (Treviño) ]
  * ResultViewGrid: wait for double-click event only if the relative result needs
    the Preview (LP: #1291950)
  * OverlayWindowButtons: trigger a queuedraw also when a child requires a redraw
    (LP: #1461618)
  * GnomeSessionManager: Request ScreenSaver (de)activation on VT changes (LP:
    #1405349)
  * UScreen, PanelService: get monitor at position, ignoring pre-multipled Gdk
    scale factor (LP: #1351591)
  * UScreen, PanelService: get monitor at position, ignoring pre-
    multipled Gdk scale factor (LP: #1351591)

 -- Marco Trevisan (Treviño) <mail@3v1n0.net> Wed, 21 Oct 2015 15:54:44 +0000

Changed in unity (Ubuntu Trusty):
status: Fix Committed → Fix Released

The verification of the Stable Release Update for unity has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers