Activity log for bug #1347735

Date Who What changed Old value New value Message
2014-07-23 14:45:02 Margarita Manterola bug added bug
2014-07-24 14:27:57 Andrea Azzarone unity (Ubuntu): assignee Andrea Azzarone (andyrock)
2014-07-24 14:28:01 Andrea Azzarone unity: assignee Andrea Azzarone (andyrock)
2014-07-24 14:28:03 Andrea Azzarone unity: importance Undecided Medium
2014-07-24 14:28:05 Andrea Azzarone unity: status New In Progress
2014-07-24 14:28:09 Andrea Azzarone unity (Ubuntu): status New In Progress
2014-07-24 14:37:19 Andrea Azzarone unity: importance Medium Low
2014-07-24 19:24:38 Andrea Azzarone unity: milestone 7.3.1
2014-07-24 21:30:59 Launchpad Janitor branch linked lp:~andyrock/unity/fix-lp-1347735
2014-08-06 01:07:24 Launchpad Janitor unity (Ubuntu): status In Progress Fix Released
2014-08-06 09:54:21 Marco Trevisan (Treviño) unity: status In Progress Fix Committed
2014-08-06 14:35:22 Launchpad Janitor branch linked lp:~unity-team/unity/prepare-7.2.3-SRU
2014-08-06 14:41:28 Marco Trevisan (Treviño) unity/7.2: importance Undecided Low
2014-08-06 14:41:28 Marco Trevisan (Treviño) unity/7.2: status New Fix Committed
2014-08-06 14:41:28 Marco Trevisan (Treviño) unity/7.2: milestone 7.2.3
2014-08-06 14:41:28 Marco Trevisan (Treviño) unity/7.2: assignee Andrea Azzarone (andyrock)
2014-08-06 14:43:16 Marco Trevisan (Treviño) unity/7.2: status Fix Committed In Progress
2014-08-06 16:04:13 Marco Trevisan (Treviño) unity (Ubuntu): importance Undecided Low
2014-09-17 01:51:52 Marco Trevisan (Treviño) description Hi, Version: 7.2.2+14.04.20140714-0ubuntu1 (trusty) Some users like to remap the way the activate capslock. For example, using gnome-tweak-tool it's possible to set the CapsLock key to behave as an extra Ctrl, or an extra Alt (or several other extras) and then set "Both shifts together toggle CapsLock". This works perfectly well inside Unity, the hardware keyboard led indicator shows up, etc. However, the lockscreen detector doesn't correctly warn or not warn when this setup is used. * If the lockscreen was activated with capslock on, then the double-shift makes capslock go away, but not the warning. * If the lockscreen was activated with capslock off, then the double-shift makes capslock on, but no warning shows up. I believe the problem is in this piece of code in unity-shared/TextInput.cpp: void TextInput::OnKeyUp(unsigned keysym, unsigned long keycode, unsigned long state) { if (!caps_lock_on && keysym == NUX_VK_CAPITAL) caps_lock_on = true; else if (caps_lock_on && keysym == NUX_VK_CAPITAL) caps_lock_on = false; } This is checking for specific key, instead of the fact that CapsLock was activated or not. [Impact] Remapped keys to activate the caps-lock are not correctly detected by the unity lockscreen [Test case] 1. Configure the keyboard so that "Both shifts together toggles CapsLock" 2. Lock the screen using Super+L or menus 3. Press both shifts together to turn the capslock on 4. The lockscreen input field should show a warning 5. Press the shifts again, and the warning should be hidden [Regression potential] None ----------------- Version: 7.2.2+14.04.20140714-0ubuntu1 (trusty) Some users like to remap the way the activate capslock. For example, using gnome-tweak-tool it's possible to set the CapsLock key to behave as an extra Ctrl, or an extra Alt (or several other extras) and then set "Both shifts together toggle CapsLock". This works perfectly well inside Unity, the hardware keyboard led indicator shows up, etc. However, the lockscreen detector doesn't correctly warn or not warn when this setup is used. * If the lockscreen was activated with capslock on, then the double-shift makes capslock go away, but not the warning. * If the lockscreen was activated with capslock off, then the double-shift makes capslock on, but no warning shows up. I believe the problem is in this piece of code in unity-shared/TextInput.cpp: void TextInput::OnKeyUp(unsigned keysym,                         unsigned long keycode,                         unsigned long state) {   if (!caps_lock_on && keysym == NUX_VK_CAPITAL)     caps_lock_on = true;   else if (caps_lock_on && keysym == NUX_VK_CAPITAL)     caps_lock_on = false; } This is checking for specific key, instead of the fact that CapsLock was activated or not.
2014-09-22 15:29:39 Marco Trevisan (Treviño) attachment added unity_7.2.3+14.04.20140826-0ubuntu1.debdiff https://bugs.launchpad.net/bugs/1347735/+attachment/4211574/+files/unity_7.2.3%2B14.04.20140826-0ubuntu1.debdiff
2014-09-23 16:04:19 Chris J Arges nominated for series Ubuntu Trusty
2014-09-23 16:04:19 Chris J Arges bug task added unity (Ubuntu Trusty)
2014-09-23 19:37:27 Chris J Arges unity (Ubuntu Trusty): status New Fix Committed
2014-09-23 19:37:30 Chris J Arges bug added subscriber Ubuntu Stable Release Updates Team
2014-09-23 19:37:34 Chris J Arges bug added subscriber SRU Verification
2014-09-23 19:37:42 Chris J Arges tags verification-needed
2014-10-20 17:08:39 Christopher Townsend tags verification-needed verification-done
2014-10-28 13:19:16 Launchpad Janitor unity (Ubuntu Trusty): status Fix Committed Fix Released
2014-10-28 13:21:45 Chris J Arges removed subscriber Ubuntu Stable Release Updates Team
2014-10-29 16:26:38 Marco Trevisan (Treviño) unity/7.2: status In Progress Fix Committed
2014-10-29 16:56:49 Marco Trevisan (Treviño) unity/7.2: status Fix Committed Fix Released
2015-02-11 16:16:02 Stephen M. Webb unity: status Fix Committed Fix Released