Change "Show Desktop" icon option label when this option is in the state where it will reverse the prior show desktop action.

Bug #1237132 reported by Dac Chartrand on 2013-10-08
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Ayatana Design
Low
John Lea
Unity
Fix Released
Low
Brandon Schaefer
7.2
Fix Released
Low
Unassigned
unity (Ubuntu)
Low
Brandon Schaefer
Trusty
Undecided
Unassigned

Bug Description

[ Impact ]

The label on the show desktop / show windows icon in the Unity Switcher does not change even when the function of the button has changed. This can be just a little bit confusing.

[ Test Case ]

(1) Open several applications with windows.
(2) Using Alt-Tab, bring up the Switcher and keeping the Alt key depressed and using the Tab key, navigate to the leftmost icon, which should be labeled "Show Desktop". Release all keys. Only the desktop should be displayed.
(3) Again using Alt-Tab, navigate back to the leftmost icon. Its label should have changed to "Restore Windows" to indicate its changed function.

[ Regression Potential ]

About the worst that could happen is the incorrect label is applied to the icon in the Switcher.

[ Other Info ]

The Ubuntu 14.04 LTS SRU has been cherry-picked from the Ubuntu 14.04 release where it has shown to be stable.

Related branches

lp:~brandontschaefer/unity/lp.1237132-fix
Christopher Townsend: Approve on 2014-08-14
PS Jenkins bot: Approve (continuous-integration) on 2014-08-14
lp:~unity-team/unity/7.2.4
Marco Trevisan (Treviño): Approve on 2014-12-17
Andrea Azzarone (azzar1) on 2013-10-09
Changed in unity:
status: New → Incomplete
tags: added: needs-design
John Lea (johnlea) on 2013-10-16
description: updated
tags: added: udp
removed: needs-design
Changed in ayatana-design:
assignee: nobody → John Lea (johnlea)
importance: Undecided → Low
Changed in unity:
importance: Undecided → Low
Changed in ayatana-design:
status: New → Fix Committed
Changed in unity:
status: Incomplete → Fix Committed
Changed in unity (Ubuntu):
status: New → Fix Committed
Changed in unity:
status: Fix Committed → Triaged
Changed in unity (Ubuntu):
status: Fix Committed → Confirmed
summary: - "Show Desktop" doesn't produce desired action
+ Change "Show Desktop" ALT-TAB option label when this option is in the
+ state where it will reverse the prior show desktop action.
Stephen M. Webb (bregma) on 2013-10-16
Changed in unity:
milestone: none → 7.2.1
Changed in unity (Ubuntu):
status: Confirmed → Triaged
importance: Undecided → Low
Stephen M. Webb (bregma) on 2014-06-04
Changed in unity:
milestone: 7.2.1 → 7.2.2
Changed in unity:
milestone: 7.2.2 → 7.2.3
Changed in unity:
milestone: 7.2.3 → 7.3.1

This is simple enough. It would also be nice if we changed the icon, though i've no clue what it should look like. Its just easier to tell the difference between an icon vs small text.

Changed in unity:
assignee: nobody → Brandon Schaefer (brandontschaefer)
Changed in unity (Ubuntu):
assignee: nobody → Brandon Schaefer (brandontschaefer)
status: Triaged → In Progress
Changed in unity:
status: Triaged → In Progress
summary: - Change "Show Desktop" ALT-TAB option label when this option is in the
- state where it will reverse the prior show desktop action.
+ Change "Show Desktop" icon option label when this option is in the state
+ where it will reverse the prior show desktop action.
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package unity - 7.3.1+14.10.20140904-0ubuntu1

---------------
unity (7.3.1+14.10.20140904-0ubuntu1) utopic; urgency=low

  [ Martin Pitt ]
  * Adjust upstart dependency to upstart-bin. (LP: #1351306)

  [ Brandon Schaefer ]
  * When Show Desktop is active, it will set the tooltip icon as
    "Restore Windows". This is per workspace. So each time show_destop
    bool is updated in PluginAdapter, the Show Desktop icon will update
    its tooltip if needed. (LP: #1237132)
  * Use CONFIG instead of CACHE to store the first_run.stamp

  [ Stephen M. Webb ]
  * update the unity manpage (LP: #1059275)

  [ Andrea Azzarone ]
  * Share lockscreen password entry between screens. (LP: #1308540)

  [ Marco Trevisan (Treviño) ]
  * IconRenderer: draw count texture at proper scaling, built by
    LauncherIcon (LP: #1353070)
  * LauncherIcon: make the Icon count width depending on the text value
    width (LP: #796527)
  * Lockscreen: scale the UI elements based on current monitor scaling
    (LP: #1292218)
  * SwitcherView: set progress on icon render args (LP: #1361679)
  * SearchBar, ActionButtons, IconRenderer: include the font scaling
    when scaling textual items
 -- Ubuntu daily release <email address hidden> Thu, 04 Sep 2014 22:12:54 +0000

Changed in unity (Ubuntu):
status: In Progress → Fix Released
Changed in unity:
status: In Progress → Fix Committed
Stephen M. Webb (bregma) wrote :

Attached debdiff between trusty-updates and SRU.

Stephen M. Webb (bregma) on 2014-12-29
description: updated

Hello Dac, or anyone else affected,

Accepted unity into trusty-proposed. The package will build now and be available at http://launchpad.net/ubuntu/+source/unity/7.2.4+14.04.20141217-0ubuntu1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in unity (Ubuntu Trusty):
status: New → Fix Committed
tags: added: verification-needed
Nekhelesh Ramananthan (nik90) wrote :

Fixed in Unity 7.2.4. Thnx for the fix.

tags: added: verification-done
removed: verification-needed
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package unity - 7.2.4+14.04.20141217-0ubuntu1

---------------
unity (7.2.4+14.04.20141217-0ubuntu1) trusty; urgency=medium

  [ Andrea Azzarone ]
  * Share lockscreen password between screens (lp: #1308540)
  * Allow a distinct pam config file for greeter and for lock-screen.
    (lp: #1305440)
  * Add an arrow activator in the lockscreen. (lp: #1332509)
  * Make sure GetScreenGeometry returns the correct value (lp: #1374785).
  * unmapped all windows prior to shutdown (lp: #1370017) (lp: #1375271)

  [ Brandon Schaefer ]
  * fix tooltip for the "Show Desktop / Restore Windows" icon in the Alt-Tab
    switcher (lp: #1237132)
  * Use CONFIG instead of CACHE to store the first_run.stamp (lp: #1328677)

  [ Eleni Maria Stea ]
  * LayoutSystem: make sure the exposed open windows are displayed in the
    preserved order (lp: #1349281).

  [ handsome_feng ]
  * added support for getting the distro name from /etc/os-release
    (lp: #1329584)

  [ Iain Lane ]
  * When grabbing keys, try prefixing "XF86" if the key isn't found. GNOME
    gives us unprefixed keys sometimes (lp: #1302885).

  [ Marco Trevisan (Treviño) ]
  * make the Launcher icon count badge width depend on the text value width
    and scaling (lp: #1353070) (lp: #1354498) (lp: #796527) (lp: #1066971)
    (lp: #1361713)
  * DecoratedWindow: make edges independent from borders and properly update
    them on actions change (lp: #1276177), (lp: #1299741), (lp: #1301776),
    (lp: #1324104), (lp: #1364225), (lp: #1373695)
  * Lockscreen: scale the UI elements based on current monitor scaling
    (lp: #1292218)
  * UnityScreen: when filtering out windows in spread, make sure we unscale
    them (lp: #1316265).
  * PanelMenuView: ensure that proper window tiles and buttons are shown at
    the right place (lp: #1384910) (lp: #1384958) (lp: #1385285)
  * SearchBar, ActionButtons, IconRenderer: include the font scaling when
    scaling textual items (lp: #1332947) (lp: #1361751) (lp: #1362162)
    (lp: #1362346).
  * ApplicationLauncherIcon: make sure we close the dash if DnD is accepted
    and the application window is about to be focused (lp: #1350331).
  * SwitcherView: set progress on icon render args (lp: #1361679).
  * LockScreenController: wait for the primary shield to get the grab
    before setting the session locked (lp: #1368427) (lp: #1371764).
  * added decorations to windows in non-focused workspaces (lp: #1383468)

  [ Stephen M. Webb ]
  * updated the unity(1) manpage to match the actual command (lp: #1059275)
  * bumped package version to match upstream

  [ Marco Trevisan (Treviño) ]
  * Preparing for unity 7.2.4
 -- Ubuntu daily release <email address hidden> Wed, 17 Dec 2014 20:52:10 +0000

Changed in unity (Ubuntu Trusty):
status: Fix Committed → Fix Released

The verification of the Stable Release Update for unity has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

Stephen M. Webb (bregma) on 2015-02-11
Changed in unity:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers