Some TestIconLoader unit tests intermittently fail during Jenkins CI

Bug #1224643 reported by Christopher Townsend on 2013-09-12
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Unity
Fix Released
Medium
Christopher Townsend
unity (Ubuntu)
Undecided
Unassigned

Bug Description

During Jenkins Continuous Integration, we get intermittent TestIconLoader unit test failures. It's usually one or more of the following tests:

TestIconLoader.TestGetOneIcon
TestIconLoader.TestGetAnnotatedIcon
TestIconLoader.TestGetColorizedIcon

Related branches

Changed in unity:
status: New → In Progress
importance: Undecided → Low
importance: Low → Medium
assignee: nobody → Christopher Townsend (townsend)
milestone: none → 7.1.1
summary: - Some TestIconLoader unit tests intermitently fail during Jenkins CI
+ Some TestIconLoader unit tests intermittently fail during Jenkins CI
PS Jenkins bot (ps-jenkins) wrote :

Fix committed into lp:unity at revision None, scheduled for release in unity, milestone 7.1.1

Changed in unity:
status: In Progress → Fix Committed
Andrea Azzarone (azzar1) wrote :
Changed in unity:
status: Fix Committed → Confirmed
PS Jenkins bot (ps-jenkins) wrote :

Fix committed into lp:unity at revision None, scheduled for release in unity, milestone 7.1.1

Changed in unity:
status: Confirmed → Fix Committed
Christopher Townsend (townsend) wrote :

So, this is STILL an issue even with a 15 second timeout: https://jenkins.qa.ubuntu.com/job/unity-saucy-i386-autolanding/249/consoleFull

I think something else is going on.

Maybe this in the console log is clue??????
ERROR 2013-09-18 19:29:43 unity.glib.dbus.proxy GLibDBusProxy.cpp:194 Unable to connect to proxy: Could not connect: No such file or directory
ERROR 2013-09-18 19:29:44 unity.glib.dbus.proxy GLibDBusProxy.cpp:194 Unable to connect to proxy: Could not connect: No such file or directory

Is this because of DBus acting up or Jenkins acting up?

Changed in unity:
status: Fix Committed → Confirmed
PS Jenkins bot (ps-jenkins) wrote :

Fix committed into lp:unity at revision None, scheduled for release in unity, milestone 7.1.1

Changed in unity:
status: Confirmed → Fix Committed
Michal Hruby (mhr3) wrote :

Fwiw IconLoader doesn't use nor need DBus, so the error is something completely unrelated.

Christopher Townsend (townsend) wrote :

Hi Michal,

I think you're right. I think the error message printed out during the failing test is a red herring. That said, do you have any idea why these tests sometimes will not complete in a timely manner? I have added up to a 15 second timeout, and they will still sometimes fail when the timer expires.

Launchpad Janitor (janitor) wrote :
Download full text (5.9 KiB)

This bug was fixed in the package unity - 7.1.0+13.10.20130920-0ubuntu1

---------------
unity (7.1.0+13.10.20130920-0ubuntu1) saucy; urgency=low

  [ Stephen M. Webb ]
  * render the Dash frame all the way to the bottom of the screen (lp:
    #1100120). (LP: #1100120)

  [ Brandon Schaefer ]
  * Ignore mouse movements if the mouse starts over a switcher icon.
    Clicking still works fine, we just wont steal focus from the alt+tab
    work. (LP: #1215630)
  * Make sure we ignore mouse movement over detail icons if the mouse
    starts over it at start. Let the mouse take selection control once
    it moves outside of any icon, vs having to enter a different icon.
    (LP: #1223037, #1223039)
  * Add an option to disable the mouse in the switcher. (LP: #1224048)
  * When the shortcut is open, and we receive a ButtonPress or KeyPress
    hide it. As this causes problems else where, and it really should
    close if the user attempts to do anything (even while holding
    super!). (LP: #932718)
  * Set an upper bound on the amount of icons we go through to check
    tooltips. As the accordion effect was causing the mouse to go
    through the icons to fast, making the test fail.
  * Make sure we move the mouse over the target icon while we are
    dragging the source icon.
  * Get the real shortcut to activate ibus. (LP: #1227056)
  * Only accept focus if the mouse moves in 3 directions on switcher
    start up if the mouse starts over the switcher window. This is an
    attempt to tell the difference between a bump and intentional
    movement. (LP: #1223630)

  [ Marco Trevisan (Treviño) ]
  * DesktopApplicationManager: added new app manager layer so that we
    can emit app events.
  * Application: add desktop_id method, and implement in
    desktop::Application.
  * Launcher: only fade the launcher when in auto-hide and dash is
    opened. (LP: #1223979, #1044926)
  * ApplicationLauncherIcon: log unity zeitgeist events on stick,
    unstick, removal and delete. (LP: #779449)
  * UnityScreen: add support for Super+Arrows shortcuts to manage the
    focused window Super+Arrows shortcut allows to move and maximize /
    restore / minimize the focused window on the screen. (LP: #992697,
    #751050)
  * Launcher: use nux::Animation for all the launcher animations This
    allows to do these when compiz requests to prepare painting, instead
    of using only an idle to perform this. (LP: #1226114, #1224766)
  * ShortcutView: use StaticCairoText instead of StaticText for
    rendering the View Improves the text alignment and visual quality.
  * UnityShell: redraw the dash also if a non-blurred area is damaged If
    the dash is damaged, but not the blurred area, it won't redraw. We
    need to draw it, in order to avoid flickering of its border. Also,
    add the redraw_view_if_damaged utility function to redraw a view if
    really needed. (LP: #1224340)
  * AnimationUtils: add utility functions to handle nux::Animation's
    start and reversion Update the whole code using nux::animation to
    use these facility functions.
  * Launcher: fix style to use postfixed-underscore for private members
    Also remove some tabs and useless members.
  * ...

Read more...

Changed in unity (Ubuntu):
status: New → Fix Released
Stephen M. Webb (bregma) wrote :

Fix Released in Nux Unity 7.1.1.

Changed in unity:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers