TabIterator doesn't correctly access to last areas of its inner list
Bug #1202423 reported by
Marco Trevisan (Treviño)
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Unity |
Fix Released
|
High
|
Marco Trevisan (Treviño) | ||
| unity (Ubuntu) |
Fix Released
|
Undecided
|
Marco Trevisan (Treviño) | ||
Bug Description
In TabIterator we have some deference of iterator.end() pointers, that are actually invalid.
This can lead to a crash.
Related branches
lp:~3v1n0/unity/memory-fixes
- PS Jenkins bot (community): Approve (continuous-integration)
- Brandon Schaefer (community): Approve
-
Diff: 1149 lines (+323/-284)22 files modifiedUnityCore/Model-inl.h (+3/-3)
dash/previews/TabIterator.cpp (+6/-9)
dash/previews/TabIterator.h (+3/-2)
debian/changelog (+4/-2)
debian/control (+1/-1)
launcher/Launcher.cpp (+1/-0)
launcher/TrashLauncherIcon.cpp (+1/-0)
tests/test_filter_multirange.h (+8/-12)
tests/test_glib_signals.cpp (+3/-4)
tests/test_grabhandle.cpp (+6/-9)
tests/test_icon_loader.cpp (+54/-44)
tests/test_launcher_entry_remote.cpp (+1/-0)
tests/test_preview_player.cpp (+1/-1)
tests/test_previews.cpp (+6/-1)
tests/test_quicklist_menu_item.cpp (+2/-0)
tests/test_scope.cpp (+8/-2)
tests/test_session_controller.cpp (+1/-1)
tests/test_tabiterator.cpp (+209/-190)
tests/test_time_util.cpp (+1/-1)
tests/test_xdnd_manager_imp.cpp (+1/-0)
unity-shared/PlacesOverlayVScrollBar.cpp (+1/-1)
unity-shared/PlacesOverlayVScrollBar.h (+2/-1)
Revision history for this message
| PS Jenkins bot (ps-jenkins) wrote | #1 |
| Changed in unity: | |
| status: | In Progress → Fix Committed |
Revision history for this message
| Stephen M. Webb (bregma) wrote | #2 |
| Changed in unity: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
Fix committed into lp:unity at revision None, scheduled for release in unity, milestone 7.1.0