LauncherDragWindow gets painted outside of the nux draw loop
Bug #1180174 reported by
Sam Spilsbury
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Unity |
Fix Released
|
Undecided
|
Sam Spilsbury | ||
unity (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned | ||
Raring |
Won't Fix
|
Undecided
|
Unassigned |
Bug Description
At the moment, the icon for the LauncherDragWindow gets painted as soon as the launcher icon is picked up and isn't delayed until nux does a paint pass. That's bad, because it can mess with the opengl state outside of when nux has the state saved, which means that for instance, some framebuffer bindings get reset to incorrect values.
The general rule of thumb is that all nux painting should happen inside of WindowThread:
Related branches
lp:~smspillaz/unity/unity.fix_1180174
- Stephen M. Webb (community): Approve
- MC Return (community): Approve
- PS Jenkins bot (community): Approve (continuous-integration)
-
Diff: 263 lines (+115/-9)5 files modifiedlauncher/Launcher.cpp (+8/-2)
launcher/LauncherDragWindow.cpp (+22/-1)
launcher/LauncherDragWindow.h (+9/-1)
launcher/SoftwareCenterLauncherIcon.cpp (+10/-4)
tests/test_launcher_drag_window.cpp (+66/-1)
Changed in unity: | |
status: | New → Confirmed |
assignee: | nobody → Sam Spilsbury (smspillaz) |
Changed in unity: | |
milestone: | none → 7.1.0 |
To post a comment you must log in.
Fix committed into lp:unity at revision None, scheduled for release in unity, milestone 7.1.0