ResultIterator.h defines functions that return const values

Bug #1163705 reported by Michi Henning on 2013-04-03
Affects Status Importance Assigned to Milestone
Status tracked in Trunk
Won't Fix
Unity Team
Won't Fix
Unity Team
Fix Committed
Unity Team
Fix Released
Unity Team
unity (Ubuntu)

Bug Description

In UnityCore/ResultIterator.h, we have things such as:

friend inline bool const operator<(const ResultIterator& lhs, const ResultIterator& rhs)


bool const IsLast();

Declaring a function to return a const value is meaningless, and the compiler ignores the const. Moreover, with -Wall -Wextra, gcc emits a warning about the ignored const and, with -Werror, produces an error.

The const return values need to be non-const.

Related branches

Changed in unity:
assignee: nobody → Michi Henning (michihenning)
status: New → In Progress
PS Jenkins bot (ps-jenkins) wrote :

Fix committed into lp:unity at revision None, scheduled for release in unity, milestone backlog

Changed in unity:
status: In Progress → Fix Committed
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package unity - 7.0.0daily13.04.10-0ubuntu1

unity (7.0.0daily13.04.10-0ubuntu1) raring; urgency=low

  [ Andrea Azzarone ]
  * Launcher icons automatically placed in the launcher by USC (or apps
    lens) fail to have running 'pips'. (LP: #1165097)

  [ Marco Trevisan (Treviño) ]
  * Unity wastes some memory by allocating multiple times the same
    texture (LP: #1166532)
  * Unity is creating multiple instances of DBusIndicators per each
    monitor (LP: #1166550)

  [ Michi Henning ]
  * ResultIterator.h defines functions that return const values (LP:

  [ Ubuntu daily release ]
  * Automatic snapshot from revision 3290
 -- Ubuntu daily release <email address hidden> Wed, 10 Apr 2013 04:03:19 +0000

Changed in unity (Ubuntu):
status: New → Fix Released
no longer affects: unity/phablet
Stephen M. Webb (bregma) wrote :

Released in Unity 7.1

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers