Network queries happen after each keystroke

Bug #1157263 reported by Jono Bacon
18
This bug affects 4 people
Affects Status Importance Assigned to Milestone
Unity
Fix Released
Critical
Unassigned
unity (Ubuntu)
Fix Released
Undecided
Unassigned

Bug Description

With the new API in the PPA it seems that a network query is happening after every keystroke which causes significant lag.

To reproduce, type "Tom Hanks" into the home lens and you will see the dash repeatedly update it's results based on each keystroke.

It should impact as well local scopes.

Tags: 100scopes
Jono Bacon (jonobacon)
description: updated
description: updated
Jorge Castro (jorge)
Changed in unity:
status: New → Confirmed
Revision history for this message
Nick Dedekind (nick-dedekind) wrote :

Dash search keystroke timeout is set to 40ms which seems a bit quick. I think we could increase this to 150ms without trouble.
Perhaps we also need a bit more intelligence here we increase the timeout the more continuous input we get.

Revision history for this message
Jono Bacon (jonobacon) wrote :

Could we track this when the user types and ship the average keystroke speed off to the smart scopes service to auto-tune the timeout?

Changed in unity:
importance: Undecided → Critical
description: updated
Revision history for this message
Brandon Schaefer (brandontschaefer) wrote :

I think this one could be fixed by fixing this bug first:
https://bugs.launchpad.net/unity/+bug/1158459

So keeping the timer, each keystroke should cancel the previous search which should speed things up. Cause I think the real problem with why its slow is it has a huge list of things its search, but it should only be searching 1 string ever (IMO). This is what is causing the lag, at lease what I think is causing it.

Revision history for this message
Paweł Stołowski (stolowski) wrote :

This has been fixed some time ago by properly using GLib.Cancellables. Closing.

Changed in unity:
status: Confirmed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.