test-gestures rebuilds every time I "make install"
Bug #1039367 reported by
Daniel van Vugt
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Unity |
Fix Released
|
Medium
|
Christopher Townsend | ||
unity (Ubuntu) |
Fix Released
|
Low
|
Christopher Townsend | ||
Raring |
Won't Fix
|
Undecided
|
Unassigned |
Bug Description
Every time I "make install", the test-gestures target rebuilds. There's something a little broken with our makefiles/
[ 97%] Copying and modifying sources under test.
[ 97%] Building CXX object tests/test-
[ 97%] Building CXX object tests/test-
[ 97%] Building CXX object tests/test-
[ 97%] Building CXX object tests/test-
Linking CXX executable test-gestures
[100%] Built target test-gestures
Related branches
lp:~townsend/unity/fix-build-test-gestures
- Marco Trevisan (Treviño): Approve
- PS Jenkins bot (community): Approve (continuous-integration)
-
Diff: 99 lines (+50/-27)2 files modifiedtests/test-gestures/CMakeLists.txt (+3/-27)
tests/test-gestures/modify_test_gestures_files.sh (+47/-0)
description: | updated |
Changed in unity: | |
status: | New → Triaged |
Changed in unity (Ubuntu): | |
status: | New → Triaged |
importance: | Undecided → Low |
Changed in unity: | |
milestone: | none → 7.0.0 |
Changed in unity: | |
milestone: | 7.0.0 → 7.0.1 |
Changed in unity: | |
milestone: | 7.0.1 → 7.1.0 |
importance: | Low → Medium |
Changed in unity: | |
assignee: | nobody → Christopher Townsend (townsend) |
Changed in unity (Ubuntu): | |
assignee: | nobody → Christopher Townsend (townsend) |
Changed in unity: | |
status: | Triaged → In Progress |
Changed in unity (Ubuntu): | |
status: | Triaged → In Progress |
To post a comment you must log in.
The test-gestures CMakeLists.txt file has some commands defined to copy some files from the Unity source to the build dir and then change some pre-defined strings within the files. It does this at every build, so these files are always changed, so they are rebuilt.
I'll see if it's possible to add some logic around those commands to only copy and sed if the Unity source file has changed.