Failing AP test: unity.tests.test_switcher.SwitcherTests.test_switcher_scroll_prev_ignores_fast_events

Bug #1008828 reported by Thomi Richards
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
unity (Ubuntu)
Invalid
Undecided
Unassigned

Bug Description

The following autopilot test:

unity.tests.test_switcher.SwitcherTests.test_switcher_scroll_prev_ignores_fast_events

Fails intermittnetly on developer machines. This is because the test relies on generating several mouse events in quick succession. This really isn't appropriate for an autopilot test, and should instead be written as a unit test. Unfortunately, unity is written in such a way that makes the input handling code much harder to put under test.

My recommendation is that we split out the logic from:

void UnityScreen::handleEvent(XEvent* event)

and codify it in a separate class that recieves events and emits signals for different actions that need to be taken. These can then be connected to the appropoiate places in unityshell. This has the advantage that the input handling code is agnostic of Compiz / X11, can be tested, is more flexible, reduces the massive size of the unityshell.cpp file, and doesn't make me want to stab my eyes out with toothpicks.

All good reasons to make it happen!

Tim Penhey (thumper)
Changed in unity:
importance: Undecided → Low
Revision history for this message
Andrea Azzarone (azzar1) wrote :

Closing considering AP is no longer actively used for unity7.

no longer affects: unity
Changed in unity (Ubuntu):
status: Confirmed → Invalid
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.