Google Calendar install from Firefox fails

Bug #1311643 reported by David Barth
22
This bug affects 1 person
Affects Status Importance Assigned to Milestone
GoogleCalendar WebApp
Medium
Justin McPherson
webapps-greasemonkey (Ubuntu)
Undecided
Unassigned
Trusty
Undecided
Robert Bruce Park

Bug Description

[Impact]

When navigating to Google Calendar and accepting the webapp integration, the webapp is not properly installed on the launcher.

[Test Case]

* install the google-calendar webapp (apt-get install unity-webapps-googlecalendar),
* navigate to http://calendar.google.com
* authenticate and verify that you see the calendar view
* accept the webapp integration offer appearing in the browser banner

* Expected result: the Google Calendar launcher icon should be installed
* Actual result: no launcher icon is installed

[Regression Potential]

The issue is a regression.

Related branches

David Barth (dbarth)
Changed in unity-webapps-googlecalendar:
assignee: nobody → Justin McPherson (justinmcp)
tags: added: webapps-hotlist
Changed in unity-webapps-googlecalendar:
importance: Undecided → Medium
status: New → Triaged
Revision history for this message
Justin McPherson (justinmcp) wrote :

If a webapp package has been pre-installed then no installation prompt will be presented (for _any_ app).

Revision history for this message
Alexandre Abreu (abreu-alexandre) wrote :

To be more precise, the behavior is different in ff & chromium. For chromium, even when you have a webapp that has been manually installed (which is different than preinstalled) and the user did not actively choose either yes or no (ie the allowed & dontask dconf lists have not been updated w/ this webapp), we show the prompt (in a subsequent session).

FF does not act this way and as soon as the webapp is installed does not prompt anything anymore.

http://bazaar.launchpad.net/~webapps/webapps-greasemonkey/trunk/view/head:/components/unity_webapps.js#L484

vs

http://bazaar.launchpad.net/~webapps/unity-chromium-extension/trunk/view/head:/chromium-extension/background-page.js#L246

Revision history for this message
Justin McPherson (justinmcp) wrote :

Should the behaviour be brought into sync?

Revision history for this message
David Barth (dbarth) wrote :

Yes, Firefox should prompt the user about the webapp even if the package is already installed. The prompt should be presented, as in Chomium, up until either the user accepts the integration or asks not to be prompted again.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package webapps-greasemonkey - 2.3.6+14.10.20140701-0ubuntu1

---------------
webapps-greasemonkey (2.3.6+14.10.20140701-0ubuntu1) utopic; urgency=low

  [ Ubuntu daily release ]
  * New rebuild forced

  [ Justin McPherson ]
  * Set a timeout value on the Notification pop-up. We want the
    notification to last a little longer to overcome redirects. - It can
    still be clicked away, and will disappear when the location bar is
    made active. (LP: #1311848)
  * Offer to install webapp if the package is already installed (but the
    user has not accepted or rejected installation). (LP: #1311643)
 -- Ubuntu daily release <email address hidden> Tue, 01 Jul 2014 08:26:16 +0000

Changed in webapps-greasemonkey (Ubuntu):
status: New → Fix Released
Changed in webapps-greasemonkey (Ubuntu Trusty):
assignee: nobody → Robert Bruce Park (robru)
status: New → Fix Committed
Revision history for this message
Chris Halse Rogers (raof) wrote : Please test proposed package

Hello David, or anyone else affected,

Accepted webapps-greasemonkey into trusty-proposed. The package will build now and be available at http://launchpad.net/ubuntu/+source/webapps-greasemonkey/2.3.6+13.10.20130920.1-0ubuntu1.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

tags: added: verification-needed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package webapps-greasemonkey - 2.3.6+13.10.20130920.1-0ubuntu1.1

---------------
webapps-greasemonkey (2.3.6+13.10.20130920.1-0ubuntu1.1) trusty; urgency=low

  [ Justin McPherson ]
  * components/unity_webapps.js:
    - Offer to install webapp if the package is already installed (LP: #1311643)
    - Set a timeout value on the Notification pop-up (LP: #1311848, #1315220)
 -- Robert Bruce Park <email address hidden> Tue, 15 Jul 2014 15:48:04 -0700

Changed in webapps-greasemonkey (Ubuntu Trusty):
status: Fix Committed → Fix Released
Mathew Hodson (mhodson)
tags: removed: verification-needed
Changed in unity-webapps-googlecalendar:
status: Triaged → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Duplicates of this bug

Other bug subscribers