Spinner not shown

[Michał Sawicz]

STEPS:
1. install image 209
2. Note not Ubutnu Logo on boot
3. Once the system start enable developer mode
4. adb shell
5. `stop unity8`
6. This will produce a crash for the spinner

This blank logo happens on Arale and krillin for sure.

EXPECTED:
I always expect to see the logo

ACTUAL:
The logo is missing on boot and missing from the spinner on `stop unity8`

The Ubuntu spinner is not shown.

ProblemType: Crash
DistroRelease: Ubuntu 15.04
Package: unity-system-compositor 0.2.0+15.04.20151216.1-0ubuntu1
Uname: Linux 3.4.67 armv7l
ApportVersion: 2.17.2-0ubuntu1.3touch1
Architecture: armhf
Date: Mon Dec 21 17:19:32 2015
ExecutablePath: /usr/bin/unity-system-compositor-spinner
ExecutableTimestamp: 1450306669
GraphicsCard:

InstallationDate: Installed on 2015-12-21 (0 days ago)
InstallationMedia: Ubuntu 15.04 - armhf (20151221-020303)
ProcCmdline: /usr/bin/unity-system-compositor-spinner
ProcCwd: /
ProcEnviron:

Signal: 11
SourcePackage: unity-system-compositor
UpgradeStatus: No upgrade log present (probably fresh install)
UserGroups:

version.libdrm: libdrm2 2.4.60-2
version.lightdm: lightdm 1.14.4-0ubuntu1
version.mesa: libegl1-mesa-dev N/A

[Michał Sawicz (saviq)]

OOPS on errors.u.c: https://errors.ubuntu.com/oops/a68a2080-a7fe-11e5-b17a-fa163e707a72

Not retraced yet as of when I'm filing this.

[Launchpad Janitor (janitor)]

Status changed to 'Confirmed' because the bug affects multiple users.

[Apport retracing service (apport)]

Stacktrace:
 #0 0xb5bfde18 in ?? ()
 No symbol table info available.
 #1 0xb5bfdc40 in ?? ()
 No symbol table info available.
 Backtrace stopped: previous frame identical to this frame (corrupt stack?)
StacktraceTop:
 ?? ()
 ?? ()

[Apport retracing service (apport)]

Thank you for your report!

However, processing it in order to get sufficient information for the
developers failed (it does not generate a useful symbolic stack trace). This
might be caused by some outdated packages which were installed on your system
at the time of the report:

no debug symbol package found for libhybris
no debug symbol package found for liblttng-ust0
no debug symbol package found for libhybris-common1
no debug symbol package found for libhardware2
no debug symbol package found for liburcu2
libandroid-properties1 version 0.1.0+git20151016+6d424c9-0ubuntu2 required, but 0.1.0+git20131207+e452e83-0ubuntu39 is available
no debug symbol package found for libandroid-properties1
no debug symbol package found for mir-test-tools
no debug symbol package found for libprotobuf-lite9
no debug symbol package found for libxkbcommon0
unity-system-compositor version 0.2.0+15.04.20151216.1-0ubuntu1 required, but 0.0.5+15.04.20150227-0ubuntu1 is available
no debug symbol package found for unity-system-compositor

Please upgrade your system to the latest package versions. If you still
encounter the crash, please file a new report.

Thank you for your understanding, and sorry for the inconvenience!

[Kevin DuBois (kdub)]

spinner is crashing while uploading some of the artwork to the gpu (specifically the wallpaper)

[Kevin DuBois (kdub)]

The other interesting bit is that a manual build and test seems to work again.... must have something to do with the deb build (and the wallpaper generation from png files in that environment)

[Kevin DuBois (kdub)]

zeroing in a bit more, when ran natively, the build system says that the wallpaper is 3bytes per pixel, and the emulated deb system is producing a 4 byte per pixel header. I'd guess that source image is 3bytes, and we're overrunning the image data when trying to upload.

[Pat McGowan (pat-mcgowan)]

stepping through it seems it segfaults on line 154
  if (image.bytes_per_pixel == 3)
        format = GL_RGB;

[Kevin DuBois (kdub)]

actually, looks like we're just missing something from USC:
http://bazaar.launchpad.net/~unity-system-compositor-team/unity-system-compositor/trunk/revision/264

[Daniel van Vugt (vanvugt)]

Kevin's analysis sounds right...

Ha, I just realized my name is on eglspinner.cpp so I might get assigned such bugs. Although I never had anything to do with eglspinner or USC, that particular code was copied from mine in Mir's examples/.

[Daniel van Vugt (vanvugt)]

Fix committed on trunk a couple of weeks ago:

------------------------------------------------------------
revno: 264 [merge]
author: Andreas Pokorny <email address hidden>
committer: Tarmac
branch nick: trunk
timestamp: Mon 2015-12-07 14:00:39 +0000
message:
  Use actual image.bytes_per_pixel to decide about GL format of pixel data.

  Approved by Alexandros Frantzis, PS Jenkins bot, Kevin DuBois.
------------------------------------------------------------

[Kevin DuBois (kdub)]

USC xenial migration is jammed up in proposed (and too many people are out on vacation to correct the problem, or so I'm told). So the fix can't land until the jam is cleared, probably have to wait until January.

[Daniel van Vugt (vanvugt)]

Fair enough. The fix is still landed in the 0.3 branch so Fix Committed is accurate. Note it's still open (Triaged) in the Ubuntu task.

[Timo Jyrinki (timo-jyrinki)]

unity-system-compositor (0.2.0+15.04.20151222.1-0ubuntu1) vivid; urgency=medium

  [ Alexandros Frantzis ]
  * tests: Fix build failure with gcc-4.9

  [ Andrea Cimitan ]
  * Updated wallpaper for spinner from unity8.

  [ Andreas Pokorny ]
  * Add clone method to StubdisplayConfigurations
  * Change keyboard handling to scan codes. (LP: #1514059, #1520422)
  * do not premultiply RGB images
  * follow the deprecation warning and use tobytes instead of tostring.

  [ Kevin DuBois ]
  * Accommodate RGB images (LP: #1528279)
  * Accommodate RGB images (LP: #1528279)

 -- Kevin DuBois <email address hidden> Tue, 22 Dec 2015 19:09:40 +0000

[Launchpad Janitor (janitor)]

This bug was fixed in the package unity-system-compositor - 0.2.0+16.04.20151222.1-0ubuntu1

---------------
unity-system-compositor (0.2.0+16.04.20151222.1-0ubuntu1) xenial; urgency=medium

  [ Alexandros Frantzis ]
  * tests: Fix build failure with gcc-4.9

  [ Andrea Cimitan ]
  * Updated wallpaper for spinner from unity8.

  [ Andreas Pokorny ]
  * Add clone method to StubdisplayConfigurations
  * Change keyboard handling to scan codes. (LP: #1514059, #1520422)
  * do not premultiply RGB images
  * follow the deprecation warning and use tobytes instead of tostring.

  [ Kevin DuBois ]
  * Accommodate RGB images (LP: #1528279)
  * Accommodate RGB images (LP: #1528279)

 -- Kevin DuBois <email address hidden> Tue, 22 Dec 2015 19:09:40 +0000