[enhancement] Unity system compositor allows connections from any Mir client

Bug #1211141 reported by Robert Ancell on 2013-08-12
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Light Display Manager
Medium
Unassigned
Mir
Fix Released
Critical
Alan Griffiths
Unity System Compositor
Critical
Unassigned

Bug Description

Currently unity-system-compositor has a Mir socket that allows any Mir client to connect to it. We should only allow clients that the display manager has spawned to connect.

Related branches

Changed in unity-system-compositor:
status: New → Triaged
importance: Undecided → Critical
Changed in unity-system-compositor:
status: Triaged → In Progress
assignee: nobody → Robert Ancell (robert-ancell)
Changed in mir:
status: New → Fix Released
importance: Undecided → Critical
Changed in lightdm:
importance: Undecided → Critical
status: New → In Progress
Changed in mir:
assignee: nobody → Alan Griffiths (alan-griffiths)
Changed in lightdm:
assignee: nobody → Robert Ancell (robert-ancell)
Daniel van Vugt (vanvugt) wrote :

I think this is a bad plan.

Running native Mir clients in USC has so far been an invaluable debugging technique. Why remove it?

Robert Ancell (robert-ancell) wrote :

Because we don't want malicious programs connecting and pretending to be the user session.

Daniel van Vugt (vanvugt) wrote :

I think we made the critical mistake of designing a solution in the bug description. All we should do is ensure the permissions are restricted on the server socket file. So other users/daemons can't display things.

If however a "malicious program" is running as yourself, then you're already compromised, and already screwed.

I just want to make sure the desktop user still has permission to run a native Mir client on their own desktop. That's really important for us to triage bugs, and has been so far.

Daniel van Vugt (vanvugt) wrote :

More work coming in lightdm or USC?

I still recommend against it :)

summary: - Unity system compositor allows connections from any Mir client
+ [enhancement] Unity system compositor allows connections from any Mir
+ client
tags: added: enhancement
Changed in lightdm:
status: In Progress → Incomplete
Changed in unity-system-compositor:
status: In Progress → Incomplete
Changed in lightdm:
assignee: Robert Ancell (robert-ancell) → nobody
importance: Critical → Medium
Changed in unity-system-compositor:
assignee: Robert Ancell (robert-ancell) → nobody
Changed in lightdm:
status: Incomplete → Invalid
Changed in unity-system-compositor:
status: Incomplete → Invalid
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers