Typing timeout breaks querying of all scopes on startup
Bug #1370483 reported by
Paweł Stołowski
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| unity-scopes-shell |
Fix Released
|
High
|
Paweł Stołowski | ||
Bug Description
The recently introduced typing timeout (rev. 143) has unexpected side effect that breaks querying of all favorite scopes on startup (rev. 135).
When Scopes object instance is created, it dispatches search to all favorite scopes, so that results are immediately available when user goes to that scope after boot. Rev 135 however fires off typing timeouts for all these searches, causing results to be invalidated, forcing new search when user goes to a favorite scope.
I think a fix for that would be to start typingTimer only when scope is currently active, unless there is a better way to only do that if we're dealing with actual typing, and not a query that is set programatically.
Related branches
lp:~stolowski/unity-scopes-shell/fix-1370483
- PS Jenkins bot (community): Approve (continuous-integration)
- Pete Woods (community): Approve
-
Diff: 17 lines (+7/-1)1 file modifiedsrc/Unity/scope.cpp (+7/-1)
Revision history for this message
| Pete Woods (pete-woods) wrote | #1 |
| Changed in unity-scopes-shell: | |
| status: | New → Confirmed |
| Changed in unity-scopes-shell: | |
| importance: | Undecided → High |
| assignee: | nobody → Pawel Stolowski (stolowski) |
| status: | Confirmed → In Progress |
| tags: | added: rtm14 |
| Changed in unity-scopes-shell: | |
| status: | In Progress → Fix Released |
To post a comment you must log in.
I think we are starting to have a somewhat confused setup in the shell "scope" class now. There is a *lot* going on there. It's a bit disappointing that the tests didn't pick up this failure :(