[Dash] Activating a preview with a scope URI for the current scope doesn't send you back to the results view

Bug #1335761 reported by Pete Woods
18
This bug affects 2 people
Affects Status Importance Assigned to Milestone
unity-scopes-shell (Ubuntu)
Fix Released
Medium
Paweł Stołowski
unity8 (Ubuntu)
Invalid
Medium
Albert Astals Cid
unity8 (Ubuntu RTM)
Invalid
Medium
Unassigned

Bug Description

You'll have to compile (prototype) the Youtube scope from source (https://launchpad.net/unity-scope-youtube/), as it's not in distro yet.

Basically the workflow is:
1) Search for something that has a result with a scope URI for the current scope. In the case of Youtube, search for "queenofficial" to get Queen's music channel.
2) Preview the first item (the channel itself), and click the search button.
3) This runs a new query for the current scope, but doesn't switch away from the preview view).
4) You will see a preview of the first video in the new results list.

Like when searching other scopes, the view should be returned to the results list, instead of saying in the preview "view".

Tags: ota-1 rtm14

Related branches

Pete Woods (pete-woods)
description: updated
description: updated
Revision history for this message
Michał Sawicz (saviq) wrote :

Are you sending HIDE_PREVIEW activation result?

Revision history for this message
Michał Sawicz (saviq) wrote :

Or whatever calls showDash()? ;)

Michal Hruby (mhr3)
Changed in unity-scopes-shell:
importance: Undecided → High
status: New → Confirmed
Revision history for this message
Paweł Stołowski (stolowski) wrote :

This is also appears to be broken for actions which have "uri" attribute set to a canned query, except for Scopes scope previews (works for favorited scopes?)

tags: added: rtm14
kevin gunn (kgunn72)
no longer affects: unity8
kevin gunn (kgunn72)
Changed in unity8 (Ubuntu):
importance: Undecided → Medium
tags: added: ota-1
tags: added: touch-2014-10-09
Pete Woods (pete-woods)
Changed in unity-scopes-shell:
importance: High → Medium
Pete Woods (pete-woods)
Changed in unity-scopes-shell (Ubuntu):
status: New → Confirmed
importance: Undecided → Medium
no longer affects: unity-scopes-shell
Revision history for this message
Paweł Stołowski (stolowski) wrote :

It seems that openScope() signal of Scope object that's emitted in such cases doesn't cause change active scope when in the preview.

kevin gunn (kgunn72)
tags: added: touch-2014-11-13
removed: touch-2014-10-09
Revision history for this message
kevin gunn (kgunn72) wrote :

@saviq - so it doesn't get lost, but this feels like it might be addressed through bug 1368670

tags: removed: touch-2014-11-13
Changed in unity8 (Ubuntu):
assignee: nobody → Michał Sawicz (saviq)
Revision history for this message
Robert Schroll (rschroll) wrote :

I have a simple scope that seems to exhibit the same problem: https://code.launchpad.net/~rschroll/+junk/multiples

Revision history for this message
Riccardo Padovani (rpadovani) wrote :

I have the same problem here: https://github.com/rpadovani/discerning-duck

Do a search for "countries in Europe", click on the first result, click on "Tell me more" - a new search is done, but the preview isn't closed

Revision history for this message
Launchpad Janitor (janitor) wrote :

Status changed to 'Confirmed' because the bug affects multiple users.

Changed in unity8 (Ubuntu):
status: New → Confirmed
kevin gunn (kgunn72)
Changed in unity8 (Ubuntu RTM):
assignee: nobody → Michał Sawicz (saviq)
status: New → Confirmed
importance: Undecided → Medium
Revision history for this message
Paweł Stołowski (stolowski) wrote :

I've just checked vivid and it's still the case. Note, the original steps to reproduce no longer apply because youtube scope doesn't seem to be producing previews for channels with 'Search' button. I'm not sure which of the existing scopes exhibit it offhand.

I've reproduced it again with slightly modifed mediascanner-video scope (added a 'Search' button to its preview). After some more tests I can conclude the following about preview buttons which have uris set to canned queries (should execute search):

* it works, when it points to a different scope than the one displaying the preview.
* it doesn't work when it points to the same scope. In such case the search is executed in the background, but preview is not dismissed. After exiting the preview manually one can see new search results proving the query was in fact executed.

Here is the change I applied to mediascanner scope for reproducing; change uri to "scope://mediascanner-music?q=" to see it working as expected because different scope needs to be opened).

=== modified file 'src/myvideos/video-scope.cpp'
--- src/myvideos/video-scope.cpp 2015-04-15 15:58:52 +0000
+++ src/myvideos/video-scope.cpp 2015-04-17 09:58:29 +0000
@@ -281,6 +281,12 @@
                 {"uri", Variant(uri)},
                 {"label", Variant(_("Play"))}
             });
+ builder.add_tuple({
+ {"id", Variant("sr")},
+ {"uri", Variant("scope://mediascanner-video?q=foo")},
+ {"label", Variant(_("Search"))}
+ });
+
         actions.add_attribute_value("actions", builder.end());
     }

Michał Sawicz (saviq)
Changed in unity8 (Ubuntu):
status: Confirmed → Triaged
Revision history for this message
Michał Sawicz (saviq) wrote :

Assuming we get notice from the Scopes object, it would be a relatively easy fix on our side.

Changed in unity8 (Ubuntu):
assignee: Michał Sawicz (saviq) → Albert Astals Cid (aacid)
Changed in unity8 (Ubuntu RTM):
assignee: Michał Sawicz (saviq) → nobody
Revision history for this message
Albert Astals Cid (aacid) wrote :

After a quick chat with Pawel we don't need any change from the unity8 side

Changed in unity8 (Ubuntu):
status: Triaged → Invalid
Changed in unity8 (Ubuntu RTM):
status: Confirmed → Invalid
Changed in unity-scopes-shell (Ubuntu):
assignee: nobody → Pawel Stolowski (stolowski)
Changed in unity-scopes-shell (Ubuntu):
status: Confirmed → In Progress
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package unity-scopes-shell - 0.5.4+15.04.20150429-0ubuntu1

---------------
unity-scopes-shell (0.5.4+15.04.20150429-0ubuntu1) vivid; urgency=medium

  [ CI Train Bot ]
  * New rebuild forced.

  [ Pawel Stolowski ]
  * Emit showDash() signal if canned query is executed for current
    scope. (LP: #1335761)
  * Reset user data set with previously executed canned query when shell
    calls setSearchQuery() (i.e.user typed a new search). (LP: #1449928)

 -- CI Train Bot <email address hidden> Wed, 29 Apr 2015 11:44:18 +0000

Changed in unity-scopes-shell (Ubuntu):
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.