Fix the way SmartScopesClient reads port from url string
Bug #1279269 reported by
Marcus Tomlinson
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| unity-scopes-api |
Fix Released
|
Low
|
Marcus Tomlinson | ||
| unity-scopes-api (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned | ||
Bug Description
The port in a url string is assumed to be at the very end of the string. This is not always the case.
Related branches
lp:~marcustomlinson/unity-scopes-api/fix_url_port_extraction
- PS Jenkins bot (community): Approve (continuous-integration)
- Paweł Stołowski (community): Approve
- Michi Henning (community): Needs Information
-
Diff: 382 lines (+276/-33)5 files modifiedinclude/unity/scopes/internal/smartscopes/SmartScopesClient.h (+5/-0)
src/scopes/internal/smartscopes/SmartScopesClient.cpp (+105/-29)
test/gtest/scopes/internal/smartscopes/SmartScopesClient/SmartScopesClient_test.cpp (+148/-0)
test/gtest/scopes/internal/smartscopes/smartscopesproxy/smartscopesproxy_test.cpp (+0/-2)
valgrind-suppress (+18/-2)
| Changed in unity-scopes-api: | |
| importance: | Undecided → Low |
| assignee: | nobody → Marcus Tomlinson (marcustomlinson) |
| Changed in unity-scopes-api: | |
| status: | New → In Progress |
Revision history for this message
| PS Jenkins bot (ps-jenkins) wrote | #1 |
| Changed in unity-scopes-api: | |
| status: | In Progress → Fix Committed |
| Changed in unity-scopes-api: | |
| status: | Fix Committed → Fix Released |
| Changed in unity-scopes-api (Ubuntu): | |
| status: | New → Fix Released |
To post a comment you must log in.
Fix committed into lp:unity-scopes-api/devel at revision 228, scheduled for release in unity-scopes-api, milestone Unknown