Possible infinite loop in scope search

Bug #1233756 reported by dobey
24
This bug affects 3 people
Affects Status Importance Assigned to Milestone
unity-scope-click
Fix Released
Critical
dobey
unity-scope-click (Ubuntu)
Fix Released
Undecided
Unassigned

Bug Description

With the fixing of Unity's handling of the results_invalidated() method, it may be possible that the usage of the method in the current click scope code will result in an infinite search loop.

Related branches

Revision history for this message
dobey (dobey) wrote :

After testing with the https://code.launchpad.net/~unity-team/unity8/scope-isactive/+merge/187179 unity8 branch which fixes the handling of invalidated results, this doesn't seem to be an issue. The results do appear a few seconds after bringing up the network, when the unity8 branch was started with no network available, indicating that the code is working correctly as-is. And the click-scope process doesn't go into an infinite loop and take up all the CPU, according to top.

Changed in unity-scope-click:
status: New → Invalid
Changed in unity-scope-click:
status: Invalid → New
Changed in unity-scope-click:
assignee: nobody → Rodney Dawes (dobey)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

Fix committed into lp:unity-scope-click at revision 73, scheduled for release in unity-scope-click, milestone Unknown

Changed in unity-scope-click:
status: New → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

Status changed to 'Confirmed' because the bug affects multiple users.

Changed in unity-scope-click (Ubuntu):
status: New → Confirmed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package unity-scope-click - 0.1+13.10.20131010-0ubuntu1

---------------
unity-scope-click (0.1+13.10.20131010-0ubuntu1) saucy; urgency=low

  [ Michal Hruby ]
  * Add a new scope which handles non-click apps and scopes. (LP:
    #1229758)

  [ Alejandro J. Cura ]
  * Send the device architecture in the click search query. (LP:
    #1234437)

  [ Rodney Dawes ]
  * Only invalidate the results in the timeout, to avoid constant
    refreshing of the search. (LP: #1233756)

  [ Ubuntu daily release ]
  * Automatic snapshot from revision 74
 -- Ubuntu daily release <email address hidden> Thu, 10 Oct 2013 10:03:25 +0000

Changed in unity-scope-click (Ubuntu):
status: Confirmed → Fix Released
dobey (dobey)
Changed in unity-scope-click:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.