dialer-app crashed with SIGSEGV in __GI___pthread_mutex_lock()

[Martin Pitt]

I regularly get this crash when running the dialer-app-autopilot tests on the Nexus G4.

Reproducer:
 * Make phone writable
 * Keep display on: adb shell "nohup powerd-cli display on"
 * install packages: adb shell "apt-get install -y ofono-phonesim-autostart dialer-app-autopilot"
 * Run tests: adb shell sudo -u phablet -i bash -ic "autopilot run -v dialer_app"

In a lot of cases, dialer_app.tests.test_calls.TestCalls.test_incoming fails with

Traceback (most recent call last):
  File "/usr/lib/python2.7/dist-packages/dialer_app/tests/test_calls.py", line 143, in test_incoming
    self.hangup()
  File "/usr/lib/python2.7/dist-packages/dialer_app/tests/test_calls.py", line 190, in hangup
    self.assertThat(fn, Eventually(Equals(None)))
  File "/usr/lib/python2.7/dist-packages/testtools/testcase.py", line 417, in assertThat
    raise MismatchError(matchee, matcher, mismatch, verbose)
MismatchError: After 10.0 seconds test failed: None != <autopilot.introspection.dbus.AbstractButton object at 0x2194990>

and the screen just stays black except for the unity panel. Then you get /var/crash/_usr_bin_dialer-app.32011.crash (You get the crash even in cases where the test case doesn't fail, it's apparently some race condition in Mir).

ProblemType: Crash
DistroRelease: Ubuntu 13.10
Package: dialer-app 0.1+13.10.20131011+autopilot0 [origin: unknown]
Uname: Linux 3.4.0-3-mako armv7l
ApportVersion: 2.12.5-0ubuntu2
Architecture: armhf
Date: Wed Oct 16 09:59:34 2013
ExecutablePath: /usr/bin/dialer-app
ExecutableTimestamp: 1381856940
InstallationDate: Installed on 2013-10-15 (0 days ago)
InstallationMedia: Ubuntu 13.10 - armhf (20131015.2)
LocalLibraries: /android/system/lib/libhardware.so /android/system/lib/libdsyscalls.so /android/system/lib/libstlport.so /android/system/lib/libgenlock.so /android/system/lib/libc.so /android/system/lib/libstdc++.so /android/system/lib/libgsl.so /android/system/lib/libEGL.so /android/system/lib/egl/libEGL_adreno200.so /android/system/lib/libGLES_trace.so /android/system/lib/egl/libGLESv1_CM_adreno200.so /android/system/lib/libgccdemangle.so /android/system/lib/libm.so /android/system/lib/libcutils.so /android/system/lib/liblog.so /android/system/lib/libcorkscrew.so /android/system/lib/libGLESv2.so /android/system/lib/libz.so /android/system/lib/egl/libGLESv2_adreno200.so /android/system/lib/libutils.so
MarkForUpload: True
ProcCmdline: dialer-app
ProcCwd: /home/phablet
Signal: 11
SourcePackage: dialer-app
StacktraceTop:
 pthread_mutex_lock () from /lib/arm-linux-gnueabihf/libpthread.so.0
 pthread_mutex_lock () from /lib/arm-linux-gnueabihf/libc.so.6
 mir::client::DisplayConfiguration::copy_to_client() const () from /usr/lib/arm-linux-gnueabihf/libmirclient.so.3
 MirConnection::create_copy_of_display_config() () from /usr/lib/arm-linux-gnueabihf/libmirclient.so.3
 mir_connection_get_display_info () from /usr/lib/arm-linux-gnueabihf/libmirclient.so.3
Title: dialer-app crashed with SIGSEGV in pthread_mutex_lock()
UpgradeStatus: No upgrade log present (probably fresh install)
UserGroups: adm autopilot cdrom dialout dip nopasswdlogin plugdev sudo tty video

[Martin Pitt (pitti)]

Running only that one test "autopilot run dialer_app.tests.test_calls.TestCalls.test_incoming" directly in an ssh session to the G4 (as user phablet) reproduces the crash as well, and runs faster.

[Apport retracing service (apport)]

StacktraceTop:
 __GI___pthread_mutex_lock (mutex=0x0) at pthread_mutex_lock.c:50
 pthread_mutex_lock (mutex=<optimized out>) at forward.c:192
 mir::client::DisplayConfiguration::copy_to_client() const () at /usr/include/arm-linux-gnueabihf/c++/4.8/bits/gthr-default.h:748
 MirConnection::create_copy_of_display_config() () at /build/buildd/mir-0.0.15+13.10.20131014/src/client/mir_connection.cpp:363
 mir_connection_get_display_info () at /build/buildd/mir-0.0.15+13.10.20131014/src/client/mir_client_library.cpp:295

[Martin Pitt (pitti)]

Adding a Mir task as the stack trace has Mir all over the place.

[Martin Pitt (pitti)]

Most probably a duplicate of bug 1233988. I'll re-test once that fix lands.

[Martin Pitt (pitti)]

Nope, I do have that Mir version, and moreover this is a segfault while bug 1233988 is an ABRT (most probably an assertion failure).

[Alexandros Frantzis (afrantzis)]

This is actually most likely a duplicate of bug 1233988. Even with all the fixes for 1233988, you will still get a abort/crash (qFatal()) if the app can't connect to the server for some reason, but you should also get a "FATAL:..." stderr (I think) message from Qt. Previously, the platform API would ignore the connection problem and used invalid objects, leading to strange crashes in mir.

So, if you can verify that you get the "FATAL: ... " message from qFatal with the newest packages, then this is essentially "dialer-app fails to connect to unity8/mir".

[Alexandros Frantzis (afrantzis)]

The exact error message is "QUbuntu: Could not create application instance" you should get is.

[Martin Pitt (pitti)]

Alexandros, but dialer-app already connected to Mir.. I see this crash while dialer-app is already visible, it just crashes in the middle of receiving a phone call. (Also, it's NOT a SIGABRT, and I don't see any "FATAL:" messages anywhere)

[Daniel van Vugt (vanvugt)]

Thank you for taking the time to report this bug and helping to make Ubuntu better. This particular bug has already been reported and is a duplicate of bug 1233988, so it is being marked as such. Please look at the other bug report to see if there is any missing information that you can provide, or to see if there is a workaround for the bug. Additionally, any further discussion regarding the bug should occur in the other report. Feel free to continue to report any other bugs you may find.

[Martin Pitt (pitti)]

Unduping for the rationale above, quickly discussed with Daniel on IRC.

[Martin Pitt (pitti)]

Seems this is fixed now, https://code.launchpad.net/~pitti/dialer-app/drop-expected-crash/+merge/199754 succeeded.

[Bill Filler (bfiller)]

this is not fixed. using build 152 on Nexus 4 the dialer-app autopilot tests (from trunk, where the test in question is re-enabled), I get the same problem as described in the original bug. Screen goes black and then the shell crashes. I am going to re-add the try catch in the dialer-app autopilot test so it doesn't fail.

[Gustavo Pichorim Boiko (boiko)]

I can reproduce that even without using autopilot, just start dialer-app from command line:

dialer-app --desktop_file_hint=/usr/share/applications/dialer-app.desktop

Then call the phone and answer the call in the snap decision. The focus will get back to the dialer-app, and as soon as you try to interact with the app, the screen will turn black, and trying to interact with the shell makes it crash.

[Launchpad Janitor (janitor)]

This bug was fixed in the package dialer-app - 0.1+14.04.20140130-0ubuntu1

---------------
dialer-app (0.1+14.04.20140130-0ubuntu1) trusty; urgency=low

  [ Bill Filler ]
  * o not pass the phone number as a parameter when pushing the live
    call view for an outgoing call. The correct value will be taken from
    the callManager. This fixes the problem of the header not updating
    when switching between multiple calls. Re-add try catch around
    autopilot test as the underlying mir/shell crash has not been fixed

  [ Martin Pitt ]
  * tests: Drop expected crash for LP#1240400, it's fixed now. (LP:
    #1240400)

  [ Gustavo Pichorim Boiko ]
  * Implement support for switching calls.
  * Fix a typo in the default avatar setting on history page.
  * Fix the call duration parsing by using Qt.formatTime() to split
    hours, minutes and seconds. (LP: #1242772)
  * o not pass the phone number as a parameter when pushing the live
    call view for an outgoing call. The correct value will be taken from
    the callManager. This fixes the problem of the header not updating
    when switching between multiple calls. Re-add try catch around
    autopilot test as the underlying mir/shell crash has not been fixed

  [ Omer Akram ]
  * Load testability driver if QT_LOAD_TESTABILITY is in the
    environment.

  [ Dimitri John Ledkov ]
  * Drop executing qmake, to query a variable, which is then not used.
    Adjust dependency on any:arch python, fixes cross-compilation.
    build-dependency installation.
 -- Ubuntu daily release <email address hidden> Thu, 30 Jan 2014 17:06:44 +0000

[Andreas Pokorny (andreas-pokorny)]

I can reproduce the issue easily too. But only when I start dialer-app from the command line. Additionally dialer-app does not crash as far as I can tell, it only terminates due to unity8 crashing.

[Andreas Pokorny (andreas-pokorny)]

just a short update - the crash does not occur when the application is launched with upstart-launch-app

[Martin Pitt (pitti)]

So should this be marked as duplicate of bug 1263182, or should Mir be fixed to not crash in this case?

[Andreas Pokorny (andreas-pokorny)]

A fix for that bug would hide the issue here, but we should not crash in that case.

When the incoming call is accepted another session is created for another dialer-app which for some reason is not launched. The final crash happens in unity-mir ApplicationManager::suspendApplication application_manager.cpp:226 (initiated by the user switching applications or going back to phone shell/launcher) when it tries to defocus and suspend the session.

I now try to investigate why the application session is invalid.

[Andreas Pokorny (andreas-pokorny)]

ApplicationManager only uses the app-id to track processes, and hence mismatches start/stop reports and authorization request.

[Launchpad Janitor (janitor)]

This bug was fixed in the package unity-mir - 0.3+14.04.20140311.1-0ubuntu1

---------------
unity-mir (0.3+14.04.20140311.1-0ubuntu1) trusty; urgency=low

  [ Michael Zanetti ]
  * expose ApplicationImage's sourceSize (LP: #1282126)

  [ Andreas Pokorny ]
  * Use the process id found in the mir::shell::Session to match it with
    the Application object. (LP: #1281075)

  [ thomas-voss ]
  * Switch to QT_NO_KEYWORDS and with that account for changes in
    process-cpp.

  [ CI bot ]
  * [cmake] Use XXX_LDFLAGS for libraries found with pkg_check_modules.
    Using the pkg given LDFLAGS resolves linking issues when cross-
    compiling
  * Add dev scripts to support cross-compilation Adapted cross compile
    scripts from mir project to support cross compilation using a basic
    armhf chroot environment populated using debootstrap - the build
    dependencies are parsed from debian/control These scripts are
    intended for development purposes only
  * Bugfix for unity-mir crash when multiple application instances with
    the same appId get started & stopped. This change also introduces
    further mocks for mir and unity-mir classes and a refactored
    ApplicationManager. The log traces where extended with more
    information on the touched application objects. (LP: #1240400)
 -- Ubuntu daily release <email address hidden> Tue, 11 Mar 2014 03:40:58 +0000