Unity 8 does not properly parse legitimate desktop files

Bug #1204595 reported by Jamie Strandboge
18
This bug affects 3 people
Affects Status Importance Assigned to Milestone
unity-mir
Medium
Gerry Boland
qtubuntu (Ubuntu)
Undecided
Unassigned

Bug Description

Basically two issues that I found:
1. Unity 8 wants '[Desktop Entry]' to be on the first line
2. Unity 8 doesn't like the spaces around '='

Unity 7 handles these fine.

Eg:

$ cat ~/.local/share/applications/com.ubuntu.developer.jdstrand.evilapp_evilapp_0.1.desktop # NOT WORKING
# Generated by "click desktophook"; changes here will be overwritten.
[Desktop Entry]
Type=Application
Terminal=false
Exec = aa-exec -p com.ubuntu.developer.jdstrand.evilapp_evilapp_0.1 -- /usr/bin/qmlscene -I /opt/click.ubuntu.com/com.ubuntu.developer.jdstrand.evilapp/0.1/backend/modules run /opt/click.ubuntu.com/com.ubuntu.developer.jdstrand.evilapp/0.1/app/evilapp.qml
Icon = /opt/click.ubuntu.com/com.ubuntu.developer.jdstrand.evilapp/0.1/app/graphics/scheming.png
Name=EvilApp
Comment=Ubuntu Evil App to test application confinement
X-Ubuntu-Touch=true
X-Ubuntu-StageHint=SideStage
X-Ubuntu-Gettext-Domain=evilapp
Path = /opt/click.ubuntu.com/com.ubuntu.developer.jdstrand.evilapp/0.1

$ cat ~/.local/share/applications/com.ubuntu.developer.jdstrand.evilapp_evilapp_0.1.desktop # WORKING
[Desktop Entry]
# Generated by "click desktophook"; changes here will be overwritten.
Type=Application
Terminal=false
Exec=aa-exec -p com.ubuntu.developer.jdstrand.evilapp_evilapp_0.1 -- /usr/bin/qmlscene -I /opt/click.ubuntu.com/com.ubuntu.developer.jdstrand.evilapp/0.1/backend/modules run /opt/click.ubuntu.com/com.ubuntu.developer.jdstrand.evilapp/0.1/app/evilapp.qml
Icon=/opt/click.ubuntu.com/com.ubuntu.developer.jdstrand.evilapp/0.1/app/graphics/scheming.png
Name=EvilApp
Comment=Ubuntu Evil App to test application confinement
X-Ubuntu-Touch=true
X-Ubuntu-StageHint=SideStage
X-Ubuntu-Gettext-Domain=evilapp
Path=/opt/click.ubuntu.com/com.ubuntu.developer.jdstrand.evilapp/0.1

Related branches

no longer affects: unity-mir (Ubuntu)
Gerry Boland (gerboland)
Changed in unity-mir:
status: New → Triaged
importance: Undecided → Medium
Michał Sawicz (saviq)
Changed in qtubuntu (Ubuntu):
status: New → In Progress
assignee: nobody → Michał Sawicz (saviq)
Revision history for this message
kevin gunn (kgunn72) wrote :

probably phone v1 ?

Michał Sawicz (saviq)
Changed in unity-mir:
milestone: none → phone-v1-freeze
assignee: nobody → Gerry Boland (gerboland)
Revision history for this message
Gerry Boland (gerboland) wrote :

What desktop files is the current code failing with? A full proper desktop file parser will appear after 1.0.

Revision history for this message
Michał Sawicz (saviq) wrote :

Can you just make sure the original points from description are taken care of? Like in my branch for qtubuntu above?

Gerry Boland (gerboland)
Changed in unity-mir:
status: Triaged → In Progress
Revision history for this message
Leo Arias (elopio) wrote :

Any news about this bug? I see two branches, but not approved.

Revision history for this message
Michał Sawicz (saviq) wrote :

The qtubuntu app manager is deprecated, but I believe this was merged into unity-mir... Gerry?

Changed in qtubuntu (Ubuntu):
status: In Progress → Invalid
assignee: Michał Sawicz (saviq) → nobody
Revision history for this message
Gerry Boland (gerboland) wrote :

Yep, this code in qtubuntu is only useful for SurfaceFlinger case, which we're not focusing upon right now. So if there's demand to fix SF bugs, these branches can be considered.

Revision history for this message
Leo Arias (elopio) wrote :

This is not urgent for me, so I'm ok with not fixing it on the deprecated component. Medium importance for the task in unity-mir sounds about right for me. Thank you.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Duplicates of this bug

Other bug subscribers