[UIFe] Display category emblems on results

Bug #1056901 reported by Michal Hruby on 2012-09-26
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Michal Hruby
unity-lens-shopping (Ubuntu)

Bug Description

== Proposed Change ==

Make sure results from the shopping lens show also the category emblem (the tiny icon on the right part of the price ribbon), similarly to the "More suggestions" categories in apps / music / video lens.

== Test ==

This is mostly visual change, the lens is using the same infrastructure as the other lenses which already display the emblems.

== Contingency? ==

Reverting the change is trivial by reverting the single commit to shopping lens that added it.

Attaching before and after screenshots.

Related branches

Michal Hruby (mhr3) wrote :
Michal Hruby (mhr3) wrote :
Changed in unity-lens-shopping:
status: New → In Progress
importance: Undecided → High
assignee: nobody → Michal Hruby (mhr3)
Michal Hruby (mhr3) on 2012-09-27
description: updated
Jeremy Bicha (jbicha) wrote :

Where does the icon for "Death Comes to Pemberley" come from? Why is it different than the others which are just using lens icons (with the exception of the shopping bag)?

Scott Kitterman (kitterman) wrote :

This is non-critical (although I understand desirable). I think it's too late for non-critical. We should focus on landing the critical changes like the online search privacy change and the shopping switch to https. Nack from me.

@Jeremy. It's a book, so the emblem is a book. The others are tangible goods like the Webcam & Roku (shopping bag) and Music (note icon)

Just to be clear, the emblems are already in Ubuntu. Searching for music in the music lens shows the musical note emblem and searching in the video lens shows them too. This bug is to fix a visual inconsistency between those lenses and the new shopping lens surfaced in the dash.

Without this fix there will be a mixture of results (books, tangible goods, music, videos) in the dash which the user will be unable to differentiate until they click through. So this bug fixes that inconsistency.

Jeremy Bicha (jbicha) wrote :

The point I was making is that I don't think anything else uses the book icon.

Mark Shuttleworth (sabdfl) wrote :

Let's address this post-release. Critical bugs are the focus now.

Scott Kitterman (kitterman) wrote :

Bug status updated based on sabdfl's comment.

Changed in unity-lens-shopping (Ubuntu):
milestone: none → quantal-updates
importance: Undecided → Medium
Changed in unity-lens-shopping:
milestone: none → 6.8.0
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package unity-lens-shopping - 6.8.0-0ubuntu1

unity-lens-shopping (6.8.0-0ubuntu1) quantal-proposed; urgency=low

  [ Łukasz 'sil2100' Zemczak ]
  * New upstream release.
    - Use music lens details page for music store results (LP: #1055684)
    - No easy way to disable online-fetched results in lenses (LP: #1054746)
    - Display category emblems on results (LP: #1056901)
    - Descriptions are missing all html tags (LP: #1058197)

  [ Didier Roche ]
  * debian/control:
    - bump libunity build-dep
 -- Didier Roche <email address hidden> Thu, 04 Oct 2012 16:46:32 +0200

Changed in unity-lens-shopping (Ubuntu):
status: New → Fix Released
Changed in unity-lens-shopping:
status: In Progress → Fix Released
Michal Hruby (mhr3) on 2012-10-12
Changed in unity-lens-shopping:
milestone: 6.8.0 → 7.0.0
status: Fix Released → Fix Committed
Changed in unity-lens-shopping (Ubuntu):
status: Fix Released → Triaged
Michal Hruby (mhr3) wrote :

The janitor comment here isn't correct, this didn't make its way to quantal yet. I updated the statuses.

Scott Kitterman (kitterman) wrote :

This will need to be done post-release, if at all for quantal. Unsubscribing the release team and adding SRU team.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers

Bug attachments