Web url regexp matches non url
Bug #948086 reported by
Angelo Compagnucci
This bug affects 2 people
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Unity |
Fix Released
|
Undecided
|
Unassigned | ||
unity-lens-files |
Fix Released
|
Wishlist
|
Angelo Compagnucci | ||
unity (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned | ||
unity-lens-files (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
Current regexp:
web_regex = new Regex ("([a-zA-
matches against non urls, like "daemon.vala". It needs to validate TLDs to be effective.
Related branches
lp:~angeloc/unity-lens-files/fix-for-948086
- Mikkel Kamstrup Erlandsen (community): Needs Fixing
- Michal Hruby (community): Approve
-
Diff: 33 lines (+15/-1)1 file modifiedsrc/url-checker.vala (+15/-1)
Changed in unity-lens-files: | |
status: | New → In Progress |
assignee: | nobody → Angelo Compagnucci (angelo-compagnucci) |
importance: | Undecided → Wishlist |
Changed in unity-lens-files: | |
status: | In Progress → Fix Committed |
Changed in unity-lens-files: | |
status: | In Progress → Fix Committed |
Changed in unity: | |
status: | New → Fix Committed |
Changed in unity: | |
milestone: | none → 5.8.0 |
Changed in unity: | |
status: | Fix Committed → Fix Released |
Changed in unity-lens-files: | |
status: | Fix Committed → Fix Released |
Changed in unity (Ubuntu): | |
status: | New → Fix Released |
To post a comment you must log in.
daemon.vala is a valid url if we disregard the fact that it doesn't have a scheme.