Application Lens Icons are blurry, compared with home screen

Bug #1271158 reported by Dimitri John Ledkov on 2014-01-21
36
This bug affects 5 people
Affects Status Importance Assigned to Milestone
Ubuntu UI Toolkit
Invalid
Undecided
Unassigned
unity-lens-applications
Undecided
Unassigned
qtbase-opensource-src (Ubuntu)
Undecided
Timo Jyrinki
qtubuntu (Ubuntu)
Undecided
Unassigned
unity8 (Ubuntu)
Undecided
Unassigned

Bug Description

Application Lens Icons are blurry, compared with home screen.

Screenshot to be attached. Compare the details on the left and right:

* Dialer, the marble phone looks 3D-ish vs washed out
* Contacts, the marble heads have perspective vs washed out
* Camera, the flash / markings below flash / the camera lens look precise vs washed out
* Gallry, the Mountain outline is sharp vs fuzzy.
* Browser, the maps outline and the XM-portals are sharp & bright vs fuzzy

Dimitri John Ledkov (xnox) wrote :

Not limited to emulator, same on device, image #140

On 21 January 2014 13:24, Alan Pope ㋛ <email address hidden> wrote:
> Not limited to emulator, same on device, image #140
>

I believe i have been seeing that from the early days of the grouper
builds way back to quantal / raring. But at the time it was hard to
judge since not all screens / apps were real (some where placeholder
screenshots).

--
Regards,

Dimitri.

Albert Astals Cid (aacid) wrote :

After some debugging I'm almost sure it's a bug in the sdk on how UnityThemeIconProvider is returning the images (the are loaded directly by path in the home scope and by image://theme/iconName in the app scope). Since if i change the code of the app scope to load the images by path directly they show sharp again

Changed in unity8:
status: New → Invalid
Albert Astals Cid (aacid) wrote :

I did some quick analysis and it seems the QIconLoader only supports square images so when we ask for the camera-app at QSize(144, 135) we get one icon that is QSize(135, 135) and then it gets scaled to QSize(144, 135) when showing looking blurry.

Maybe we would need to provide our own QIconEngine in QUbuntuTheme of qtubuntu (based on the private QIconLoaderEngine?) that does not force that square icons restriction?

Albert Astals Cid (aacid) wrote :

Ignore my last comment please, i think i got confused by the debuging i did

Albert Astals Cid (aacid) wrote :

I actually think it's a bug in Qt now, this small code

#include <QGuiApplication>
#include <QDebug>
#include <QIcon>

int main(int argc, char **argv)
{
    QGuiApplication a(argc, argv);
    QIcon::setThemeName("ubuntu-mobile");
    QIcon i = QIcon::fromTheme("camera-app");
    qDebug() << i.pixmap(QSize(144, 135));
    qDebug() << i.pixmap(QSize(108, 99));
    qDebug() << i.pixmap(QSize(144, 135));
}

is returning

QPixmap(QSize(144, 135) )
QPixmap(QSize(105, 99) )
QPixmap(QSize(105, 99) )

that doesn't make much sense to me.

Albert Astals Cid (aacid) wrote :

I'd say that https://codereview.qt-project.org/#change,76210 should fix the issue, i'm recompiling qt on the phone to confirm it.

Albert Astals Cid (aacid) wrote :

Yes, i can confirm that qtbase rebuilt with that patch fixes the problem.

Changed in qtubuntu:
status: New → Invalid
Changed in unity-lens-applications:
status: New → Invalid
Changed in ubuntu-ui-toolkit:
status: New → Invalid
Changed in qtbase-opensource-src (Ubuntu):
status: New → In Progress
Changed in qtbase-opensource-src (Ubuntu):
assignee: nobody → Timo Jyrinki (timo-jyrinki)
Timo Jyrinki (timo-jyrinki) wrote :

Both backports merged to packaging trunks.

Qt 5.2: fix available in qt5-beta2 PPA (version 5.2.0+dfsg-1ubuntu1~trusty1~test13)

Qt 5.0.2: fix available in https://launchpad.net/~canonical-qt5-edgers/+archive/qt5-beta1/+packages and added to get a landing slot in the landing plan https://docs.google.com/a/canonical.com/spreadsheet/ccc?key=0Au6idq7TkpUUdGNWb0tTVmJLVzFZd0doV3dVOGpWemc#gid=0

Changed in qtbase-opensource-src (Ubuntu):
status: In Progress → Fix Committed
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package qtbase-opensource-src - 5.0.2+dfsg1-7ubuntu18

---------------
qtbase-opensource-src (5.0.2+dfsg1-7ubuntu18) trusty; urgency=medium

  [ Albert Astals ]
  * Add 0001-Do-not-overwrite-basePixmap-of-QIconLoader-PixmapEnt.patch:
    - Backport an upstreamed fix to blurry icons (LP: #1271158)

  [ Łukasz 'sil2100' Zemczak ]
  * Add fix_destroy_qapp_segfault.diff:
    - Fix a segfault when QWidget element gets freed after the main
      application exits. Do not assume qApp is present. It's already
      fixed in upstream Qt 5.2 (LP: #1273306)
 -- Timo Jyrinki <email address hidden> Thu, 06 Feb 2014 11:57:09 +0000

Changed in qtbase-opensource-src (Ubuntu):
status: Fix Committed → Fix Released
Michał Sawicz (saviq) on 2017-03-13
affects: qtubuntu → qtubuntu (Ubuntu)
Michał Sawicz (saviq) on 2017-03-13
affects: unity8 → unity8 (Ubuntu)
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers