Fix object ownership issues between JS and C++
Bug #1482131 reported by
Marcus Tomlinson
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| unity-js-scopes |
Fix Released
|
Undecided
|
Alexandre Abreu | ||
Bug Description
One particular issue I noticed is when we return a SearchQuery object from ScopeBase:
Related branches
lp:~marcustomlinson/v8-cpp/test-gc
- Alexandre Abreu (community): Approve
-
Diff: 533 lines (+222/-88)7 files modifiedsrc/internal/class.h (+102/-39)
src/internal/convert.h (+35/-27)
src/run.h (+5/-0)
tests/objects/module.cpp (+2/-0)
tests/objects/test.cpp (+59/-16)
tests/objects/test.h (+17/-5)
valgrind.supp (+2/-1)
lp:~webapps/unity-js-scopes/cleanup-bindings
- WebApps: Pending requested
-
Diff: 3177 lines (+1372/-1008)48 files modifiedREADME.md (+1/-2)
debian/control (+0/-1)
examples/simple-click/src/js-scope.webapps_js-scope.js (+9/-9)
examples/simple/simple.js (+8/-4)
examples/soundcloud/soundcloud.ini (+13/-0)
examples/soundcloud/soundcloud.js (+226/-0)
src/bindings/CMakeLists.txt (+0/-1)
src/bindings/index.js (+4/-7)
src/bindings/src/action-metadata.cc (+14/-5)
src/bindings/src/action-metadata.h (+7/-7)
src/bindings/src/activation-query-proxy.cc (+60/-0)
src/bindings/src/activation-query-proxy.h (+50/-0)
src/bindings/src/activation-query.cc (+61/-0)
src/bindings/src/activation-query.h (+47/-0)
src/bindings/src/addon.cc (+225/-114)
src/bindings/src/canned-query.cc (+0/-40)
src/bindings/src/canned-query.h (+0/-45)
src/bindings/src/categorised-result.cc (+0/-72)
src/bindings/src/categorised-result.h (+0/-46)
src/bindings/src/category-renderer.cc (+0/-31)
src/bindings/src/category-renderer.h (+0/-43)
src/bindings/src/category.cc (+0/-48)
src/bindings/src/category.h (+0/-43)
src/bindings/src/column-layout.cc (+0/-86)
src/bindings/src/column-layout.h (+0/-46)
src/bindings/src/common.cc (+120/-0)
src/bindings/src/common.h (+37/-0)
src/bindings/src/preview-query-proxy.cc (+52/-0)
src/bindings/src/preview-query-proxy.h (+48/-0)
src/bindings/src/preview-query.cc (+34/-25)
src/bindings/src/preview-query.h (+11/-7)
src/bindings/src/preview-reply.cc (+6/-4)
src/bindings/src/preview-reply.h (+5/-3)
src/bindings/src/preview-widget.cc (+31/-75)
src/bindings/src/preview-widget.h (+2/-16)
src/bindings/src/result.cc (+16/-57)
src/bindings/src/result.h (+32/-20)
src/bindings/src/scope-base.cc (+82/-46)
src/bindings/src/scope-base.h (+4/-7)
src/bindings/src/search-query-proxy.cc (+52/-0)
src/bindings/src/search-query-proxy.h (+48/-0)
src/bindings/src/search-query.cc (+14/-32)
src/bindings/src/search-query.h (+2/-6)
src/bindings/src/search-reply.cc (+17/-44)
src/bindings/src/search-reply.h (+14/-2)
src/launcher/config.h.in (+2/-2)
src/tool/config.h.in (+2/-2)
src/tool/main.cc (+16/-10)
| Changed in v8-cpp: | |
| assignee: | nobody → Marcus Tomlinson (marcustomlinson) |
| status: | New → In Progress |
| Changed in v8-cpp: | |
| status: | In Progress → Fix Committed |
| Changed in unity-js-scopes: | |
| status: | New → Fix Committed |
| Changed in unity-js-scopes: | |
| assignee: | nobody → Alexandre Abreu (abreu-alexandre) |
| Changed in v8-cpp: | |
| status: | Fix Committed → Fix Released |
| Changed in unity-js-scopes: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
I'm now taking the approach of supporting smart pointers across the v8-cpp bridge, so that we can leave the reference counting and cleanup to the builtin RAII functionality of these constructs.