Icons for verb actions appear in the global menu
Bug #1196998 reported by
Lars Karlitski
This bug affects 2 people
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Unity GTK+ module |
Fix Committed
|
Medium
|
William Hua | ||
| unity-gtk-module (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned | ||
Bug Description
Ubuntu hasn't shown actions icons in menus for quite some time now, but they've recently reappeared in the global menu.
That's probably because unity-gtk-module doesn't respect the 'menus-have-icons' setting when pulling an icon out of a GtkImageMenuItem. However, since that has been deprecated in gtk (because it puts the icon into the margin of the menu instead of aligning it with the beginning of the labels), my suggestion is to simply not show icons from GtkImageMenuItems.
Icons that have are packed in any other type of menu item should continue to be shown.
Related branches
lp:~attente/unity-gtk-module/only-noun-icons
- Lars Karlitski (community): Approve
- PS Jenkins bot (community): Approve (continuous-integration)
-
Diff: 151 lines (+74/-54)1 file modifiedlib/unity-gtk-menu-item.c (+74/-54)
| Changed in unity-gtk-module: | |
| assignee: | nobody → William Hua (attente) |
| status: | New → Confirmed |
| importance: | Undecided → Medium |
| Changed in unity-gtk-module: | |
| status: | Confirmed → In Progress |
Revision history for this message
| PS Jenkins bot (ps-jenkins) wrote | #1 |
| Changed in unity-gtk-module: | |
| status: | In Progress → Fix Committed |
Revision history for this message
| Launchpad Janitor (janitor) wrote | #2 |
| Changed in unity-gtk-module (Ubuntu): | |
| status: | New → Fix Released |
To post a comment you must log in.
Fix committed into lp:unity-gtk-module at revision 297, scheduled for release in unity-gtk-module, milestone Unknown