5-desktop-integration-settings.patch in Chromium 24 breaks Settings

[Dmitry Shachnev]

Quoting from comments on bug 1099828:

> Confirming. Bug fixed in 24.0.1312.56-0ubuntu0.12.10.1~cm0quantal1 and now the settings tab is completely clear. Every time the settings tabs is opened, the console logs:
> Uncaught TypeError: Cannot set property 'onchange' of null", source: chrome://settings-frame/options_bundle.js (5788)
> Clearing cache and all settings which includes profile wiping does not solve the problem.

I don't know whether the "onchange" warning is related to that page not working, but it is caused by this line (https://bazaar.launchpad.net/~webapps/unity-chromium-extension/trunk/view/head:/chromium-patches/stable-24.0.1312.52/5-desktop-integration-settings.patch#L486):

+ $('promptIntegrationForAnyWebsite').onchange = function () {

[Paweł Kowalik (pkowalik)]

Are you sure this bug is related to the unity-chromium-extensions ? For me it also affects the Lubuntu version (24.0.1312.56-0ubuntu0.12.10.1~cm0quantal1) which default does not include any unity package.

[Dmitry Shachnev (mitya57)]

Yes, Chromium in Chad's PPA (and in Ubuntu repos) is built with Unity
integration patches from this branch.

[Paweł Kowalik (pkowalik)]

Confirming then, as it affects multiple users.

[Chad Miller (cmiller)]

chromium-browser_24.0.1312.56-0ubuntu0.12.10.1~cm1quantal1 doesn't have this problem.

[Chad Miller (cmiller)]

Marking "invalid" because it's not against a released package and other statuses would confuse people.

[Dmitry Shachnev (mitya57)]

Chad: thanks for quick response! I can confirm it is fixed in the new version (for some reason I was using ~cm0quantal1 until now).

[Dmitry Shachnev (mitya57)]

... But my terminal output now shows me this:

"Uncaught TypeError: Cannot read property 'uncommitted' of null", source: chrome://settings-frame/options_bundle.js (2616)

Where line 2616 is:

 // Listen for pref changes.
 Preferences.getInstance().addEventListener(this.pref, function(event) {
> if (event.value.uncommitted && !self.dialogPref)
     return;
   self.updateStateFromPref_(event);
   updateDisabledState_(self, 'notUserModifiable', event.value.disabled);
   self.controlledBy = event.value.controlledBy;
 });

[Alexandre Abreu (abreu-alexandre)]

mitya57: it is being fixed by this branch (being reviewed) https://code.launchpad.net/~abreu-alexandre/unity-chromium-extension/chromium-v24-fix-undefined-preference-settings-exception

[Dmitry Shachnev (mitya57)]

Alexandre: thanks for fixing that!