ToolbarButton can't be disabled
Bug #1202245 reported by
Günter Schwann
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Ubuntu UI Toolkit |
Fix Released
|
Critical
|
Tim Peeters | ||
Unity Action API |
Invalid
|
Undecided
|
Antti Kaijanmäki | ||
ubuntu-ui-toolkit (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
When setting "enabled" to false for a ToolBarButton, or it's Action the icon and text is grey.
But when clicking on it, onTriggered() is still called. So practically it's not disabled.
Related branches
lp:~tpeeters/ubuntu-ui-toolkit/ToolbarButton-disable
- PS Jenkins bot: Approve (continuous-integration)
- Cris Dywan: Approve
-
Diff: 169 lines (+36/-24)7 files modifiedcomponents.api (+2/-1)
modules/Ubuntu/Components/AbstractButton.qml (+1/-1)
modules/Ubuntu/Components/ActionItem.qml (+11/-3)
modules/Ubuntu/Components/Panel.qml (+5/-5)
modules/Ubuntu/Components/Popups/ActionSelectionPopover.qml (+2/-0)
modules/Ubuntu/Components/TextInputPopover.qml (+14/-14)
tests/resources/toolbar/toolbar.qml (+1/-0)
Changed in ubuntu-ui-toolkit: | |
assignee: | nobody → Tim Peeters (tpeeters) |
importance: | Undecided → High |
Changed in ubuntu-ui-toolkit: | |
importance: | High → Critical |
Changed in ubuntu-ui-toolkit: | |
status: | New → In Progress |
Changed in unity-action-api: | |
assignee: | nobody → Antti Kaijanmäki (kaijanmaki) |
Changed in ubuntu-ui-toolkit: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
Not a bug in unity-action-api, as the trigger() signal does check if the action is enabled before emitting signals. UITK most probablty calls triggered() instread of trigger() and thus bypasses the checks.