Window minization animation isn't mirrored in right-to-left locales.

Bug #952864 reported by Haggai Eran
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
unity-2d
Fix Released
Undecided
Haggai Eran

Bug Description

Minimizing a window in unity-2d displays an animation of a rectangle diminishing into the launcher. When using a right-to-left locale, the animation still goes to the left side of the screen, even though the launcher is on the right side, as you can see in the attached screencast.

Tags: rtl

Related branches

Revision history for this message
Haggai Eran (haggai-eran) wrote :
tags: added: rtl
Revision history for this message
Haggai Eran (haggai-eran) wrote :

I think this can be fixed by changing the calls to setIconGeometry in LauncherList.qml, but I'll have to try that.

Changed in unity-2d:
assignee: nobody → Haggai Eran (haggai-eran)
status: New → In Progress
Revision history for this message
Gerry Boland (gerboland) wrote :

I think it's further down the stack, somewhere we set an X window atom which tells windows where to minimise to. It's called _NET_WM_ICON_GEOMETRY. I've not looked to see where we set this though

Revision history for this message
Haggai Eran (haggai-eran) wrote : Re: [Bug 952864] Re: Window minization animation isn't mirrored in right-to-left locales.

If I understand correctly, calling setIconGeometry in LauncherList.qml will
call Application::setIconGeometry, which causes a call
to wnck_window_set_icon_geometry to be made.

I'm not sure though how to get the x coordinate of the right edge of the
screen inside QML, to calculate the new icon geomtry in RTL.
The declarative view class exposes the globalPosition property with the top
left coordinate of the shell. Should I expose also its width there?

Revision history for this message
Haggai Eran (haggai-eran) wrote :

The attachment shows the animation after applying the patch at lp:~haggai-eran/unity-2d/rtl-icon-geometry-952864.

I took it while using VirtualBox, so it might be a little choppy.

Changed in unity-2d:
status: In Progress → Fix Committed
Revision history for this message
Albert Astals Cid (aacid) wrote :

This was released with Unity-2d 5.7

Changed in unity-2d:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.