Dash - Update category header keyboard navigation focus state
Bug #893966 reported by
Gerry Boland
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Ayatana Design |
Fix Released
|
High
|
John Lea | ||
| Unity |
Fix Released
|
High
|
Andrea Azzarone | ||
| unity-2d |
Won't Fix
|
High
|
Unassigned | ||
| unity (Ubuntu) |
Fix Released
|
High
|
Andrea Azzarone | ||
Bug Description
When using keyboard navigation of the dash, category headings only highlight the "See X more results" string when focussed. In cases when this string is not there (say 1-4 results), there is no visual indication of when this element gets focus.
Steps to Repro
1. Open Dash
2. Perform a search where one of the categories has few enough elements to not be collapsible.
3. Hit down to highlight this Category Header.
Expected Result
Visual indication that this header is focussed
Actual Result
No visual indication.
-------
Desired resolution: see https:/
Related branches
lp:~azzar1/unity/focus-highlight-category-headers
- Thomi Richards (community): Approve
- Alex Launi: Pending requested
- John Lea: Pending (design) requested
-
Diff: 753 lines (+265/-92)12 files modifiedplugins/unityshell/src/DashStyle.cpp (+1/-1)
plugins/unityshell/src/DashStyle.h (+4/-0)
plugins/unityshell/src/DashView.cpp (+3/-1)
plugins/unityshell/src/FilterBar.cpp (+0/-1)
plugins/unityshell/src/IconTexture.cpp (+2/-2)
plugins/unityshell/src/LensBar.cpp (+2/-2)
plugins/unityshell/src/LensView.cpp (+5/-4)
plugins/unityshell/src/PlacesGroup.cpp (+173/-68)
plugins/unityshell/src/PlacesGroup.h (+27/-12)
plugins/unityshell/src/SearchBar.cpp (+2/-1)
tests/autopilot/autopilot/emulators/unity.py (+10/-0)
tests/autopilot/autopilot/tests/test_dash.py (+36/-0)
lp:~tiagosh/unity-2d/fix-dash-highlights
- PS Jenkins bot (community): Approve (continuous-integration)
- jenkins (community): Approve (continuous-integration)
- Michał Sawicz: Needs Fixing
- Xi Zhu: Pending requested
-
Diff: 218 lines (+68/-32)7 files modifiedshell/dash/CategoryHeader.qml (+16/-1)
shell/dash/FilterLoader.qml (+20/-4)
shell/dash/FilterPane.qml (+11/-16)
shell/dash/LensButton.qml (+5/-9)
shell/dash/LensView.qml (+3/-1)
shell/dash/MultiRangeButton.qml (+12/-0)
shell/dash/TickBox.qml (+1/-1)
| description: | updated |
| description: | updated |
| tags: | added: udp |
| Changed in ayatana-design: | |
| assignee: | nobody → John Lea (johnlea) |
| importance: | Undecided → High |
| status: | New → Fix Committed |
| Changed in unity: | |
| assignee: | nobody → Andrea Azzarone (andyrock) |
| milestone: | none → backlog |
| importance: | Undecided → High |
| status: | New → In Progress |
| Changed in unity-2d: | |
| status: | New → Confirmed |
| summary: |
- [dash] Highlight only on "Show X more results" in category headings + Dash - Update category header keyboard navigation focus state |
| Changed in unity-2d: | |
| importance: | Undecided → High |
| Changed in unity (Ubuntu): | |
| assignee: | nobody → Andrea Azzarone (andyrock) |
| Changed in unity-2d (Ubuntu): | |
| importance: | Undecided → High |
| Changed in unity-2d: | |
| status: | Confirmed → Triaged |
| Changed in unity (Ubuntu): | |
| status: | New → In Progress |
| Changed in unity-2d (Ubuntu): | |
| status: | New → Triaged |
| Changed in unity (Ubuntu): | |
| importance: | Undecided → High |
| Changed in unity: | |
| milestone: | backlog → 5.2.0 |
Revision history for this message
| Andrea Azzarone (azzar1) wrote | #1 |
Revision history for this message
| Andrea Azzarone (azzar1) wrote | #2 |
| Changed in unity: | |
| milestone: | 5.2.0 → 5.4.0 |
| Changed in unity: | |
| status: | In Progress → Fix Committed |
| Changed in unity (Ubuntu): | |
| status: | In Progress → Fix Committed |
| Changed in unity: | |
| status: | Fix Committed → Fix Released |
| Changed in unity-2d: | |
| milestone: | none → 5.6 |
| Changed in unity (Ubuntu): | |
| status: | Fix Committed → Fix Released |
| Changed in unity-2d: | |
| milestone: | 5.6 → 5.8 |
| Changed in unity-2d: | |
| milestone: | 5.8 → 5.10.0 |
Revision history for this message
| Xi Zhu (xi.zhu) wrote | #3 |
| Changed in unity-2d: | |
| status: | Triaged → In Progress |
| Changed in unity-2d: | |
| assignee: | nobody → Gerry Boland (gerboland) |
| Changed in unity-2d: | |
| milestone: | 5.10.0 → 5.12 |
| Changed in unity-2d: | |
| milestone: | 5.12 → 5.14 |
| no longer affects: | unity-2d (Ubuntu) |
| Changed in ayatana-design: | |
| status: | Fix Committed → Fix Released |
| tags: |
added: reviewedbydesignp removed: udp |
| Changed in unity-2d: | |
| assignee: | Gerry Boland (gerboland) → nobody |
| status: | In Progress → Won't Fix |
To post a comment you must log in.
