[dash] Keyboard navigation in the dash is in the wrong direction in right-to-left languages
Bug #886686 reported by
Haggai Eran
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| unity-2d |
Fix Released
|
Medium
|
Unassigned | ||
Bug Description
When using the keyboard to navigate in the dash, under a right-to-left locale, the left key moves the cursor to the right, while the right key moves the cursor to the left. The effect of these keys should be reversed to match the reverse rendering of the items in the dash.
Related branches
lp:~haggai-eran/unity-2d/rtl-rebased
- Gerry Boland (community): Needs Fixing
-
Diff: 307 lines (+78/-16)11 files modifiedlauncher/Launcher.qml (+21/-1)
launcher/LauncherList.qml (+5/-4)
libunity-2d-private/src/edgehitdetector.cpp (+1/-1)
libunity-2d-private/src/focuspath.cpp (+18/-4)
libunity-2d-private/src/launchermenu.cpp (+3/-1)
panel/applets/appname/appnameapplet.cpp (+3/-1)
places/GridViewWithSpacing.qml (+2/-0)
places/LensBar.qml (+1/-1)
places/MultiRangeSelectionBar.qml (+4/-2)
places/RatingStars.qml (+6/-1)
places/dash.qml (+14/-0)
lp:~haggai-eran/unity-2d/rtl-keyboard-navigation-886686
- Albert Astals Cid (community): Approve
-
Diff: 818 lines (+454/-190)12 files modifiedlibunity-2d-private/src/CMakeLists.txt (+1/-0)
libunity-2d-private/src/focuspath.cpp (+2/-1)
libunity-2d-private/src/launchermenu.cpp (+2/-1)
libunity-2d-private/src/utils.cpp (+43/-0)
libunity-2d-private/src/utils.h (+30/-0)
shell/common/utils.js (+14/-0)
shell/dash/LensBar.qml (+2/-1)
shell/dash/RatingStars.qml (+1/-1)
shell/launcher/LauncherList.qml (+6/-4)
tests/launcher/menu_tests.rb (+18/-182)
tests/launcher/menu_tests_common.rb (+225/-0)
tests/launcher/menu_tests_rtl.rb (+110/-0)
| Changed in unity-2d: | |
| status: | New → Confirmed |
| importance: | Undecided → Medium |
| summary: |
- Keyboard navigation in the dash is in the wrong direction in right-to- - left languages + [dash] Keyboard navigation in the dash is in the wrong direction in + right-to-left languages |
| Changed in unity-2d: | |
| status: | Confirmed → Fix Committed |
Revision history for this message
| Albert Astals Cid (aacid) wrote | #1 |
| Changed in unity-2d: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
This was part of Unity-2d 5.7