[launcher] Trash icon should indicate when it has deleted elements

Bug #715611 reported by Jonas Diaz on 2011-02-09
This bug affects 6 people
Affects Status Importance Assigned to Milestone
Ayatana Design
Andrea Grandi
unity-2d (Ubuntu)

Bug Description

Trash Icon in panel should indicate when it has deleted elements in it, so it can be easier to identify and we could save one click, because we would not need to right click on the icon to know if it contain any deleted element.

Related branches

Florian Boucault (fboucault) wrote :

Subscribing Ayatana Design to get input from the designers.

Changed in unity-2d:
status: New → Confirmed
summary: - Trash Icon in panel should indicate when it has deleted elements
+ [launcher] Trash icon should indicate when it has deleted elements
Didier Roche (didrocks) wrote :

It's already the case in unity itself, the icon change thanks to an awesome contributor's patch :) Marking the unity task as invalid. Unity2d needs to have the same icon and logic then.

Changed in unity:
status: New → Invalid
Changed in ayatana-design:
status: New → Fix Released
Changed in unity-2d:
importance: Undecided → Medium
milestone: none → 3.8
Changed in unity-2d:
milestone: 3.8 → 3.10
tags: added: delta-with-3d
Changed in unity-2d:
milestone: 3.10 → none
Changed in unity-2d:
assignee: nobody → Seshu Reddy Cheedepudi (seshucl)

Unassigned myself, just to be sure that I'm not holding this.

Changed in unity-2d:
assignee: Seshu Reddy Cheedepudi (seshucl) → nobody
Didier Roche (didrocks) on 2011-05-31
Changed in unity-2d (Ubuntu):
status: New → Confirmed
Andrea Grandi (andreagrandi) wrote :

It's quite easy to implement (at least in Qt :P ).

We should use the QFileSystemWatcher class and call the method "addPath" passing the ~/.Trash/ folder as parameter.
Each time we delete file and they go to the trash or if we empty the trash, the "directoryChanged" signal is called.
When signal is called we simply check: if the directory is empty then we use the empty icon, else we use the full trash icon.

I would be glad to implement it, but I really don't know where it would fit in the whole unity-2d code. Any idea?

p.s: Better to keep discussing development details here or do you prefer if I do it on #ayatana@Freenode ?

Andrea Grandi (andreagrandi) wrote :

The fix is almost ready! I need to tune the code a bit but I've already coded, tested and... it works!
Now let's see how I can do to send you the patch. Stay tuned!

Changed in unity-2d:
assignee: nobody → Andrea Grandi (andreagrandi)
Andrea Azzarone (azzar1) on 2011-06-03
Changed in unity-2d:
status: Confirmed → In Progress
Didier Roche (didrocks) on 2011-06-06
Changed in unity-2d (Ubuntu):
status: Confirmed → In Progress
Olivier Tilloy (osomon) on 2011-06-08
Changed in unity-2d:
milestone: none → 3.10
status: In Progress → Fix Committed
Didier Roche (didrocks) on 2011-06-08
Changed in unity-2d (Ubuntu):
status: In Progress → Fix Committed
Tyler R (trowe) wrote :

Very nice to see this fix, thank you.

Open question: is it possible to get the Unity 3d trash icons?

Changed in unity-2d:
milestone: 3.10 → 3.8.8
Didier Roche (didrocks) on 2011-06-14
Changed in unity-2d:
status: Fix Committed → Fix Released
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package unity-2d - 3.8.8-0ubuntu1

unity-2d (3.8.8-0ubuntu1) oneiric; urgency=low

  [ Didier Roche ]
  * new upstream release:
    - [spread] Corruption when switching workspaces after windows have been
      moved to other workspaces (LP: #760787)
    - [launcher] launcher won't fully paint, corrupted view (LP: #764690)
    - [launcher] icons no longer active after an incomplete drag (LP: #768812)
    - drag from dash to launcher (LP: #662616)
    - Don't create windows over the launcher (LP: #688816)
    - [launcher] Does not reveal when hovering over the left edge of the
      screen (LP: #760537)
    - UIFe: Launcher - update launcher reveal interaction to make it more
      accessible to first time users (LP: #754583)
    - [launcher] Trash icon should indicate when it has deleted elements
      (LP: #715611)
    - When windows open for the first time they should not hide the launcher
      (LP: #723878)
    - double clicks should be disabled on bfb/Place launcher icon/double key
      press (LP: #766776)
    - [dash][launcher] Should use real transparency when a compositing manager
      is running (LP: #794042)
    - [dash] Thunderbird icon is pixelated (LP: #767115)
    - [panel] Hovering the mouse cursor over the BFB reveals the current
      window’s menu (LP: #793403)
    - [panel] Hovering the mouse cursor away from the appmenu applet doesn’t
      hide the menu (LP: #793406)
    - unity-2d: does not parse QT_GRAPHICSSYSTEM env var (LP: #791852)
    - Cannot drag applications from dash to desktop (LP: #756614)
  * debian/control:
    - unity-2d-panel recommends the indicator, not unity-2d
    - appmenu-gtk and appmenu-qt are already provided by indicator-appmenu
    - remove other meaningless recommends
  * debian/libunity-2d-private0.install:
    - install everything in Unity2d private directory

  [ Florian Boucault ]
  * debian/unity-2d-launcher.install:
    - do not install usr/lib/qt4/imports/UnityApplications/ anylonger as all of
      UnityApplications features have been moved to the Unity2d QML plugin
      installed by libunity-2d-private0
  * debian/control:
    - unity-2d-places and unity-2d-spread do not depend on unity-2d-launcher.
      All they need is now in libunity-2d-private0.
 -- Didier Roche <email address hidden> Tue, 14 Jun 2011 16:14:18 +0200

Changed in unity-2d (Ubuntu):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Duplicates of this bug

Other bug subscribers